feat(rsc): remove hard RSDW requirement - #3123
Conversation
commit: |
|
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
e05b08f to
df13c9c
Compare
|
/bigbonk review for issues |
|
/bigbonk review for issues |
|
@james-elicx Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
|
/bigbonk review for issues |
1 similar comment
|
/bigbonk review for issues |
|
/bigbonk review for issues You have a hard 10-minute workflow limit. Timebox the review, prioritize the highest-risk actionable regressions, stop exploratory testing early enough to synthesize, and post your findings or an explicit no-findings verdict before the timeout. |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
|
Posted 1 actionable inline review finding. |
|
/bigbonk review for issues You have a hard 10-minute workflow limit. Review the current exact head, prioritize the highest-risk actionable regressions, stop exploratory testing early enough to synthesize, and post your findings or an explicit no-findings verdict before the timeout. Pay particular attention to the just-addressed manual RSC distinct-plugin-copy validation. |
|
Posted 1 actionable inline review finding. Focused RSC suites pass: 17/17. |
|
/bigbonk review for issues You have a hard 10-minute workflow limit. Review the current exact head, prioritize the highest-risk actionable regressions, stop exploratory testing early enough to synthesize, and post findings or an explicit no-findings verdict before timeout. Focus on whether the manual RSC manager-identity validation and genuine distinct-copy regression fully address the prior finding without breaking supported manual, auto, or Pages-only configurations. |
|
LGTM! |
1 participant
Summary
@vitejs/plugin-rscby defaultreact-server-dom-webpackoverrideValidation
vp test run tests/init.test.ts tests/react-rsc-compatibility.test.ts tests/app-router-rsc-plugin.test.tsvp test run tests/app-router-dev-server.test.ts tests/pages-router.test.ts tests/build-optimization.test.ts tests/deploy.test.tsPLAYWRIGHT_PROJECT=app-rsdw-override-prod pnpm run test:e2ePLAYWRIGHT_PROJECT=app-rsc-isolated-standalone pnpm run test:e2evp checkDiff size
Most touched files are one-line dependency removals across App Router examples and fixtures. The shared lockfile and isolated E2E setup account for most changed lines; runtime behavior is concentrated in the RSC plugin/configuration and React compatibility helpers.