Repository navigation
Fix durable-objects routing for list IDs that contain "add" - #109
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The example matched routes with substring checks such as "/add" in url.path, so GET /address-book/show was handled as an add request and failed with an IndexError (HTTP 500). Match the action path segment exactly instead, and return 404 for /<list_id>/add without a message.
Contributor
|
Looks like this PR is doing the same thing with (#110). I merged that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
durable-objectsexample picks a route with substring checks ("/add" in url.path,"/show" in url.path). Any path that contains/addanywhere is treated as an add request, even when the action isshow.For example,
GET /address-book/showtakes the add branch, readsurl.path.split("/")[3], raisesIndexError, and returns HTTP 500 instead ofNo messages.GET /room-1/addwithout a message fails the same way.This change matches the action path segment exactly:
/<list_id>/add/<message>adds a message./<list_id>/showshows messages./<list_id>/addwithout a message, returns 404.Testing
test_durable_objectsnow also requests/address-book/showand/room-1/add.1 failed(assert 500 == 200at the/address-book/showrequest).1 passed.uv run ruff check .anduv run ruff format --checkpass.