This repository was archived by the owner on Oct 12, 2026. It is now read-only.
Repository navigation
Conversation
haranishi
marked this pull request as ready for review
October 11, 2026 08:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
正常な
browser.close()の終了処理で発生するWebSocketのerrorイベントが、console.errorとして記録される問題を修正します。Browser.closeの送信、transportのclose、WebSocketのcloseイベントで終了状態を記録し、終了処理中のerrorログを抑制します。稼働中のエラーは引き続き記録します。認証情報や実ブラウザーを必要としない5つの回帰テストと、テスト用CIを追加しました。
Normal
browser.close()can emit WebSocket error events during shutdown and create misleading error logs. Track shutdown when sendingBrowser.close, closing the transport, or receiving a close event, and suppress error logs once shutdown starts. Errors in active sessions remain visible.Add five credential-free regression tests and a dedicated pull-request workflow.
Validation:
npm run test:unitinpackages/playwright-cloudflare/tests).npm run buildinpackages/playwright-cloudflarepassed.Closes #230.