Restrict test HTTP egress to loopback#5506
Open
clockwork-labs-bot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Tightens
allow_loopback_http_for_testsso it only permits HTTP egress to loopback IP addresses. With the feature enabled, IPv4 addresses outside127.0.0.0/8and IPv6 addresses outside::1are rejected by the same IP filter used for literal hosts and DNS results.The production/default behavior is unchanged: loopback remains blocked, private/special-purpose ranges remain blocked, and normal public addresses remain allowed.
API and ABI breaking changes
None.
Expected complexity level and risk
Testing
LC_ALL=C LANG=C PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo test -p spacetimedb-core host::instance_env::test::blocks_ --libLC_ALL=C LANG=C PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo test -p spacetimedb-core --features allow_loopback_http_for_tests host::instance_env::test::blocks_ --lib