C# Clean Up#5500
Draft
lisandroct wants to merge 132 commits into
Draft
Conversation
1) Created exception to `check_global_json_policy` to allow for .NET 8 templates to be generated. 2) Removed .NET 10 DLLs from SDK to prevent Unity issue. 3) Updated NativeAOT smoketest test include `packageSourceMapping` in `NuGet.Config`.
…SDK` for Windows builds
- Add --dotnet-version flag to build/publish/init commands for explicit .NET version control - Fix smoketests to use local SpacetimeDB.Runtime/BSATN.Runtime packages (not public NuGet) - Fix CLI binary path detection for debug vs release builds - Add NativeAOT-LLVM output paths (native/ subdirectory) to csharp.rs - Force .NET 8 for C# templates in template tests to match template TFM
…rsion `25` from `29`
…imental` can install
JasonAtClockwork
requested changes
Jul 9, 2026
| where DbConnection : DbConnectionBase<DbConnection, Tables, Reducer>, new() | ||
| where Tables : RemoteTablesBase | ||
| { | ||
| internal const bool IsTesting = false; |
Contributor
There was a problem hiding this comment.
This breaks dotnet test for sdks\csharp\tests~ due to the SnapshotTests.cs sets IsTesting = true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Wait for #4915 to be merged.
Description of Changes
Just clean up to remove style and syntax warnings.
API and ABI breaking changes
None.
Expected complexity level and risk
Testing
crates/bindings-csharpbuilds and tests pass