core: Attempt to repair databases with wrong host type#4619
Queued
core: Attempt to repair databases with wrong host type#4619
Conversation
Prior to #4549 the host type in `st_module` was always set to wasm. We now correctly use the host type from the database, but the module may in fact be a JS module. So if launching it as a wasm module fails, try JS instead. If this succeeds, the module is definitely a JS module, so attempt to repair `st_module` in this case.
kim
force-pushed
the
kim/core/repair-host-type
branch
from
7cf0742 to
2287476
Compare
joshua-spacetime
approved these changes
Mar 12, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to #4549 the host type in
st_modulewas always set to wasm. We now correctly use the host type from the database, but the module may in fact be a JS module. So if launching it as a wasm module fails, try JS instead. If this succeeds, the module is definitely a JS module, so attempt to repairst_modulein this case.Expected complexity level and risk
2
Testing