CI - Skip PR approval check on external PRs#4604
Merged
clockwork-labs-bot merged 1 commit intomasterfrom Mar 11, 2026
Merged
Conversation
jdetter
approved these changes
Mar 11, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
…4611) # Description of Changes #4604 skipped the check run for external PRs, but because it needs to post a separate commit status (see #4578), this was not the right solution. We need to _run_ the check but trivially post a success on external PRs. Sigh. # API and ABI breaking changes None. # Expected complexity level and risk 1 # Testing I don't know how to test github workflows. Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
It doesn't have permission to run on external PRs, but that's kinda okay since external PRs are rarely authored by clockwork-labs-bot anyway.
API and ABI breaking changes
None.
Expected complexity level and risk
1
Testing
None