Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where barter stall transactions could incorrectly deduct too many coins from the claim treasury when both the stall inventory and treasury contained coins.
Previously, the code calculated how many coins should come from the treasury (
removed_from_treasury), but the validation and deduction logic mistakenly used the full payout amount (removed_coins). This caused the treasury to be charged for the entire payout instead of only the shortfall after stall inventory coins were used.Changes
removed_from_treasuryby usingremoved_coinsdirectly instead ofcoin_item[0].quantity.claim_local.treasury < removed_from_treasurychecks that the treasury has the amount needed after stall reduction, rather thanclaim_local.treasury < removed_coinswhich checks against the full payout valueBug Replication
Expected:
Actual: