fix(skills): improve iOS integration with complete push notification setup#14
fix(skills): improve iOS integration with complete push notification setup#14pmTouchedTheCode wants to merge 1 commit into
Conversation
…setup - Add complete AppDelegate pattern with all delegate methods for push notifications (didRegisterForRemoteNotificationsWithDeviceToken, willPresent, didReceive) - Add SwiftUI + AppDelegate hybrid pattern for SwiftUI apps - Make interactive mode more proactive about file automation - Add automated NSE file creation (NotificationService.swift, Info.plist, entitlements) to install and ios-setup skills - Clearly distinguish CAN vs CANNOT automate in skill documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughThe PR updates iOS documentation and workflow instructions across multiple files. It adds SwiftUI/AppDelegate initialization patterns in embedded skills, replaces manual iOS setup steps with automated workflows in skill markdown files, and updates interactive mode guidance to emphasize automation-oriented instructions rather than strict workflow patterns. Changes
Possibly Related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing this PR — the changes are no longer applicable after the command-mode architecture refactor in #22. What happened:
The goals of this PR (proactive iOS automation, better push notification patterns) are now addressed differently through the preparation task flow in #22. |
Summary
Problem
The
/integrateskill had three issues when performing iOS integration:Changes
1. Updated integration skill iOS patterns (
src/lib/embedded-skills.ts)UNUserNotificationCenterDelegateconformancedidRegisterForRemoteNotificationsWithDeviceTokenfor token registrationdidFailToRegisterForRemoteNotificationsWithErrorfor error handlingwillPresentfor foreground notificationsdidReceivefor notification tap handling2. Updated install skill (
src/lib/skills/install/SKILL.md)3. Updated interactive mode instruction (
src/lib/skills.ts)4. Updated iOS setup skill (
src/lib/skills/ios-setup/SKILL.md)Test plan
/integrateon a sample iOS project and verify SDK initialization includes delegate methodsbun run check && bun testto verify no regressions🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Enhancement
✏️ Tip: You can customize this high-level summary in your review settings.