Bump uuid and @rspack/cli in /build/rspack#13
Conversation
Removes [uuid](https://github.com/uuidjs/uuid). It's no longer used after updating ancestor dependency [@rspack/cli](https://github.com/web-infra-dev/rspack/tree/HEAD/packages/rspack-cli). These dependencies need to be updated together. Removes `uuid` Updates `@rspack/cli` from 1.7.10 to 2.0.4 - [Release notes](https://github.com/web-infra-dev/rspack/releases) - [Commits](https://github.com/web-infra-dev/rspack/commits/v2.0.4/packages/rspack-cli) --- updated-dependencies: - dependency-name: uuid dependency-version: dependency-type: indirect - dependency-name: "@rspack/cli" dependency-version: 2.0.4 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
📝 WalkthroughWalkthroughThe ChangesRspack CLI dependency upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build/rspack/package.json`:
- Around line 10-11: package.json lists `@rspack/cli`@2.0.4 while `@rspack/core`
remains at ^1.3.18, causing a peer dependency conflict; update `@rspack/core` to a
v2-compatible version (e.g., ^2.0.0) and add or bump `@rspack/dev-server` to a
matching ^2.x release in build/rspack/package.json, then review
build/rspack/rspack.serve-out.config.mts (devServer and config option usage) to
adjust any deprecated/renamed options to the Rspack v2 API so `@rspack/cli`,
`@rspack/core`, and `@rspack/dev-server` versions are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b9147546-72ec-4eec-9656-e2951ce9c5ee
⛔ Files ignored due to path filters (1)
build/rspack/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
build/rspack/package.json
| "@rspack/cli": "^2.0.4", | ||
| "@rspack/core": "^1.3.18", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check peer dependencies and verify compatibility
# Check the peer dependencies of `@rspack/cli` 2.0.4
echo "=== `@rspack/cli` 2.0.4 peer dependencies ==="
npm view `@rspack/cli`@2.0.4 peerDependencies
# Check if `@rspack/dev-server` is used and needs updating
echo -e "\n=== Checking for `@rspack/dev-server` usage ==="
rg -n "`@rspack/dev-server`" build/rspack/
# Check the configuration file for any deprecated or changed APIs
echo -e "\n=== Checking configuration file ==="
cat build/rspack/rspack.serve-out.config.mtsRepository: cliff-security/vscode
Length of output: 5167
🌐 Web query:
@rspack/cli version 2 migration guide breaking changes from version 1
💡 Result:
Breaking changes for @rspack/cli v2 when migrating from v1 (grounded in the official v1→v2 upgrade guide and v2 release notes): 1) Node.js requirement changed (Node 18 no longer supported) Rspack v2 requires a minimum Node.js version of 20.19+ or 22.12+, and Node.js 18 is no longer supported. [1] 2) Pure ESM packaging: @rspack/cli is now ESM-only (CommonJS builds removed) @rspack/core, @rspack/cli, @rspack/dev-server, and @rspack/plugin-react-refresh are now published as pure ESM packages, with CommonJS builds removed. [1] 3) @rspack/dev-server is no longer a default dependency of @rspack/cli @rspack/cli no longer depends on @rspack/dev-server by default. If you use the rspack dev or rspack serve commands, install @rspack/dev-server manually. [1] 4) Built-in analyzer removed; --analyze flag removed The built-in webpack-bundler-analyzer has been removed from @rspack/cli, and the --analyze flag is no longer available. [1] 5) Dev server option changes (proxy / watchFiles, etc.) The v2 upgrade guide notes that some devServer options have changed (including Server.proxy and devServer.watchFiles). [1] 6) Default devtool behavior changed (when using @rspack/cli) When mode is development, the default devtool changed from eval to cheap-module-source-map. [1] When mode is production and you are using @rspack/cli, the default devtool changed from source-map to false. [1] Additional CLI-related breaking changes mentioned at the v2 release level The v2 release announcement also summarizes that @rspack/cli no longer depends on @rspack/dev-server by default (aligning with the upgrade guide), reflecting the dependency streamlining. [2] Where to find the complete, “authoritative” checklist Use the official migration page “Upgrading from v1 to v2” in rspack.rs, which is explicitly described as listing breaking changes from Rspack 1.x to 2.0. [1] Sources: [1] https://rspack.rs/guide/migration/rspack_1.x [2] https://www.rspack.dev/blog/announcing-2-0
Citations:
Critical peer dependency conflict: @rspack/cli v2 with @rspack/core v1 (and dev-server v2 required)
In build/rspack/package.json (lines 10-11), @rspack/cli@2.0.4 declares peer deps @rspack/core: ^2.0.0-0 (and @rspack/dev-server: ^2.0.0-0), but the file keeps @rspack/core at ^1.3.18. This guarantees a peer dependency conflict during install and can break rspack serve/dev-server behavior. Upgrade @rspack/core (and ensure @rspack/dev-server) to matching Rspack v2 versions, and confirm build/rspack/rspack.serve-out.config.mts devServer/config options still match v2 expectations.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@build/rspack/package.json` around lines 10 - 11, package.json lists
`@rspack/cli`@2.0.4 while `@rspack/core` remains at ^1.3.18, causing a peer
dependency conflict; update `@rspack/core` to a v2-compatible version (e.g.,
^2.0.0) and add or bump `@rspack/dev-server` to a matching ^2.x release in
build/rspack/package.json, then review build/rspack/rspack.serve-out.config.mts
(devServer and config option usage) to adjust any deprecated/renamed options to
the Rspack v2 API so `@rspack/cli`, `@rspack/core`, and `@rspack/dev-server`
versions are consistent.
Removes uuid. It's no longer used after updating ancestor dependency @rspack/cli. These dependencies need to be updated together.
Removes
uuidUpdates
@rspack/clifrom 1.7.10 to 2.0.4Release notes
Sourced from @rspack/cli's releases.
... (truncated)
Commits
744af1echore: release v2.0.4c9e86b8perf(cli): lazy load json stream helpers (#14079)c0db17fdocs(cli): update cli option descriptions (#14071)361ecdefix(cli): remove process title startup overhead (#14061)9a2ef24chore(deps): update patch npm dependencies (#14055)3c6700cfix(cli): write logger trace output to file by default (#14022)dfcccd6chore: release version 2.0.3 (#14015)ed2742achore: enable tsgo for dts generation (#13952)3998196chore(deps): update patch npm dependencies (#13959)45e3a8achore: enable Rslint for more packages and fix lint issues (#13934)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit