feat: add typed task status view - #97
Merged
Bosun-Josh121 merged 1 commit intoJul 29, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe agent-vault contract adds typed task lifecycle status reporting, shares stale evaluation with force completion, increments its contract version, and adds tests for status boundaries, completion precedence, cancelled tasks, and threshold changes. ChangesTask status lifecycle
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an authoritative typed on-chain lifecycle status for vault tasks so clients do not need to duplicate the contract's completion and staleness rules.
Related issue
Closes #85
Changes
TaskStatuscontract enum withActive,Stale, andCompletedget_task_status(task_id)withNonefor unknown tasksforce_complete_stale_taskelapsed > thresholdboundary and finalized-task precedenceCONTRACT_VERSIONfrom 2 to 3 for the public interface changeTesting
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test(102 passed)git diff --checkChecklist
CONTRACT_VERSIONwas bumped for the public interface changeSummary by CodeRabbit
New Features
get_task_statusview.Bug Fixes