Skip to content

test(expo): enable R8 in Android release tests #9974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliotgevers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(expo): enable R8 in Android release tests #9974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1227bc
test(expo): enable R8 in Android release tests
eliotgevers Sep 29, 2026
9bd6c1d
fix(expo): supply narrow R8 rule for release fixtures
eliotgevers Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-expo-release-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Prevent Android release builds with R8 from failing on the missing Kotlin `MustUseReturnValues` annotation.
6 changes: 4 additions & 2 deletions .github/workflows/expo-native-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
with:
path: ${{ steps.native-build-key.outputs.artifact }}
# Bump the version when native build commands change.
key: expo-native-build-v1-${{ runner.os }}-${{ matrix.expo-sdk }}-${{ matrix.platform }}-${{ matrix.run-e2e == true && 'e2e' || 'build' }}-${{ env.E2E_INSTANCE_NAME }}-${{ steps.native-build-key.outputs.hash }}
key: expo-native-build-minified-v2-${{ runner.os }}-${{ matrix.expo-sdk }}-${{ matrix.platform }}-${{ matrix.run-e2e == true && 'e2e' || 'build' }}-${{ env.E2E_INSTANCE_NAME }}-${{ steps.native-build-key.outputs.hash }}

- if: steps.native-build-cache.outputs.cache-hit != 'true'
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
Expand Down Expand Up @@ -211,7 +211,9 @@ jobs:
- name: Build Android fixture
if: matrix.platform == 'android' && steps.native-build-cache.outputs.cache-hit != 'true'
working-directory: ${{ env.FIXTURE_DIR }}
run: pnpm build:android
run: |
pnpm build:android -Pandroid.enableMinifyInReleaseBuilds=true -Pandroid.enableShrinkResourcesInReleaseBuilds=true
Comment thread
eliotgevers marked this conversation as resolved.
test -s android/app/build/outputs/mapping/release/mapping.txt

# The module's Robolectric tests need an Expo host project for expo-modules-core, so they run in the fixture.
# The packed module leaves out its tests, so they are copied in from the repo.
Expand Down
1 change: 1 addition & 0 deletions packages/expo/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ android {
versionCode 1
versionName "1.0.0"
buildConfigField "String", "CLERK_EXPO_VERSION", "\"${clerkExpoVersion}\""
consumerProguardFiles "proguard-rules.pro"
}

buildTypes {
Expand Down
1 change: 1 addition & 0 deletions packages/expo/android/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-dontwarn kotlin.MustUseReturnValues