fix(ui): Fix OrganizationSwitcher avatar flash and polish popover styling#9112
Conversation
🦋 Changeset detectedLatest commit: 3c2c3fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR patches ChangesOrganizationSwitcher Polish
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
| // Decode the (typically cached) avatar bytes before presenting so a freshly-mounted | ||
| // <img> paints on its first frame instead of flashing the avatar background for a tick. | ||
| // Safe for avatar-sized images: decode is off-thread/sub-ms and only affects already-fetched bytes. | ||
| decoding='sync' |
There was a problem hiding this comment.
This is used throughout the components, so a org profiles members tab has this used in the table. Do you think this is ok? I am not to familiar with the impacts of usage here.
There was a problem hiding this comment.
Yea was chatting with claude abt this. they're basically all so small and all our lists are capped from pagination at around 10 that it is negligible. shouldn't use it willy nilly, but in this case we're fine
| '&[aria-expanded="true"]': { | ||
| backgroundColor: 'var(--alpha)', | ||
| color: 'var(--accentHover)', | ||
| }, |
412b25f to
3c2c3fb
Compare
Description
Follow up PR imporving popover anims here
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit