Repository navigation
fix(clerk-js): use custom signInUrl for factor-one and factor-two URLs in OAuth callbacks - #10171
Draft
NicolasLopes7 wants to merge 1 commit into
Draft
NicolasLopes7 wants to merge 1 commit into
NicolasLopes7 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d7b60e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a CodeRabbit review comment from #9947 that was not addressed before merge. The issue was flagged as "Major" priority.
Problem: When a custom
signInUrlis provided viahandleRedirectCallback(e.g., for embedding sign-in on a custom page or domain), thenavigateToFactorOneandnavigateToFactorTwofunctions were building URLs using only the dashboard-configureddisplayConfig.signInUrl, ignoring the custom URL provided in the params.Impact: This means users directed to start OAuth sign-in at a custom URL would be redirected to a different URL (the dashboard default) when they need to select between multiple enterprise SSO connections or complete two-factor authentication. This breaks the user experience for custom integrations.
Solution: Update both
navigateToFactorOneandnavigateToFactorTwoto useparams.signInUrl || displayConfig.signInUrlas the base URL, matching the pattern already used bynavigateToSignIn. This ensures consistency across all sign-in navigation flows.Tests: Added tests covering:
References:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change