Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 532d1a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
maxyinger
force-pushed
the
contact-list-grid-rows
branch
from
October 13, 2026 22:07
5e4422f to
280bec7
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… place Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
maxyinger
force-pushed
the
connection-description-motion
branch
from
October 13, 2026 22:19
3084779 to
532d1a4
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Section.CollapsibleDescription, a description line that opens and closes on the content it is given, and gives the connected accounts and Web3 wallets sections one row per provider that switches between its offered and connected states in place. Connecting a provider expands its identifier or address into the same row that offered "Connect"; removing the connection collapses it out again and the row offers "Connect" once more, without the row remounting or moving.The part. It follows the measured-height variant of the row recipe that
Field.MessageandSection.Erroruse (feedbackStyles.collapse/message,useMessageHeight,useHeldMessage): the track transitionsheightfrom the measured var at--cl-duration-slow, on--cl-ease-enteropening and--cl-ease-in-outclosing; the text fades in after afastdelay and out atfaston--cl-ease-exit, leaving the flow pinned to the bottom so the last content rides the moving edge until the row has closed. Reduced motion cuts the height and keeps the fade. The gap var is set toSection.Content's row gap, so a closed description costs nothing and an open one sits exactly where a plainSection.Descriptiondoes. Content present when the part first mounts shows at once, with the first frame'stransition: nonekept so the measured var landing after mount cannot start a transition; a description that opens later enters from its starting style.truncatekeeps the text to one line with an ellipsis, withtitlecarrying the full value. The plainSection.Descriptionis unchanged.Two details worth knowing when reading the styles:
max-content. A truncating text child hasoverflow: hidden, which gives a grid item no automatic minimum size, so anautotrack would follow the wrapper's animated height instead of the text and the measurement would read 0.text-wrap: in current browserstext-wrapsetstext-wrap-mode, which overrides the truncation'swhite-space: nowrap.The rows. Each section view used to render connected items and providers to connect as two lists of different row components, so connecting swapped one row for another. Each now renders one ordered list through
useProviderRows(hooks/use-provider-rows.ts): a connected item takes its provider's id as its key when that provider is no longer offered, so the row that offered "Connect" is the row that shows the connection and vice versa; a further item of the same provider (a second MetaMask wallet) and an item whose provider is still offered (an unverified wallet) keep their own id; a key is held for as long as its item is present; anduseStableOrderkeeps rows where they were first shown, connected items first. The models now setproviderId(the strategy) onUserProfileConnectedAccountandUserProfileWeb3Wallet, which the swingset fixtures already carried.UserProfileConnectedAccountRowViewandUserProfileWeb3WalletRowVieweach takeaccount/walletorproviderand render the sameSection.Row, media and label either way, with the description, the badges, the Connect button or the menu, and everySection.Errorswitching in place. A removal trigger registers withuseListRemovalFocusonly while its row is connected.The badges in these two labels (
Disconnected,Primary,Unverified) keep their current cut; giving them the small-element enter/exit would mean sharing the contact rows'SlotItemand badge styles, which belong with the row-motion work onprofile-list-row-motion.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code