fix(init): improve established Apple app setup and interactive flow - #493
Draft
seanperez29 wants to merge 16 commits into
Draft
seanperez29 wants to merge 16 commits into
seanperez29 wants to merge 16 commits into
Conversation
🦋 Changeset detectedLatest commit: 5dd8c8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This was referenced Sep 23, 2026
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 23, 2026 21:55
0fb2729 to
f5c3ae4
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 23, 2026 22:15
f5c3ae4 to
9dad444
Compare
seanperez29
added this pull request to stack #491
September 24, 2026 18:27
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 24, 2026 19:08
16a5158 to
bf3211e
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 24, 2026 19:33
bf3211e to
d391a67
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 24, 2026 21:06
d391a67 to
9828ea1
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 24, 2026 21:48
9828ea1 to
2750f13
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 24, 2026 22:32
2750f13 to
237d6ee
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 24, 2026 23:21
237d6ee to
2cac744
Compare
seanperez29
force-pushed
the
sean/ios-established-app-operation-gates
branch
from
September 25, 2026 00:15
2cac744 to
5dd8c8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Established Apple apps with custom startup configuration could be blocked from independent SDK linkage or native registration. This change allows each operation when its own prerequisites are proven, preserves custom Swift configuration and runtime-key uncertainty, and makes the interactive setup flow easier to review.
Safety boundaries
Each operation retains its checks for target identity, SDK compatibility, file ownership, source discovery, and approved changes. Selecting
--appdoes not prove that a custom runtime key matches that application. Existing application UI is preserved unless the user opts into replacing a verified starter screen.Validation
Current integrated head:
5dd8c8ca9d918910449e65496864c51c6576f9a4.git diff --check, and all 4,257 unit tests passed.5dd8c8capassed all 4,257 unit tests and compilation. All nine branch heads passed their local checks independently.clerk-cli-real-xcode-corpus/reports/2026-09-24-entitlement-packaging.md.Earlier validation
UI validation recorded at
16a5158e33943af475cfdfee0c1c8e1ffbe0697c:git diff --check. Lint retains the existing unused-parameter warning incommands/apps/shared.ts.clerk initon the new ClerkHelloDemo project, including prebuilt UI, native registration, and Sign in with Apple configuration. The blank project built for Simulator with Xcode 26.5 before setup.Earlier integrated validation at
9dad4449f7ec561e32e314f94d523ff4908b2ca5covered 24 real-Xcode-derived PBX/JSON scenarios and two incomplete-source subcases: dry run, apply, unchanged rerun, and Doctor. All 104 compared project/source files retained identical bytes and modes; dry-run and Doctor JSON matched the preceding integrated head after normalizing temporary paths. That published head also passed GitHub's credential-backed E2E suite on September 24.The earlier
f5c3ae48head passed 28 unsigned builds with Xcode 26.5 and Xcode 27.2 beta. The full Xcode corpus and those builds were not rerun for the subsequent presentation changes. Local 1Password authorization previously timed out; no local credential-backed E2E success is claimed. Signed Apple sign-in inside a running app remains a separate validation step.Stack