-
Notifications
You must be signed in to change notification settings - Fork 5
fix(deploy): fix misleading and missing text in the clerk deploy wizard and help #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shane-kercheval
merged 24 commits into
main
from
shane/grow-1235-fix-misleading-and-missing-text-in-the-clerk-deploy-wizard
Sep 18, 2026
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6bb21b2
Fix misleading text in clerk deploy wizard and help
shane-kercheval bfcefa0
Address review of clerk deploy wording changes
shane-kercheval e612a8b
Fix contradictions found in deploy wording self-review
shane-kercheval 78a549d
Address reviewer round on deploy self-review fixes
shane-kercheval cc961ea
Keep every DNS record in the zone file on resume
shane-kercheval 71e72f6
Separate the confirmation screen from the typed domain
shane-kercheval 33d8316
Name each DNS record host one way and link the Domains page
shane-kercheval f8157f3
Tell users to choose a consent-screen name, not reuse Clerk's
shane-kercheval c43d72a
Close a skipped-DNS deploy with "DNS pending", not "Success"
shane-kercheval f6a0f3b
Only promise an OAuth step on the DNS screen when one is coming
shane-kercheval 704e590
Say what the DNS check looks for
shane-kercheval d68c414
Name the DNS provider and both options after a failed check
shane-kercheval ddb5fb7
Say what is outstanding when the DNS screen has no records to add
shane-kercheval 255ad36
Build the DNS screen's next-step sentence in one place
shane-kercheval 53b33a0
Mention email records only when one is listed
shane-kercheval 241bbd1
Write both resume sentences out instead of patching one
shane-kercheval 57c189b
Name the DNS handoff's two record lists
shane-kercheval d69e056
Describe the Google consent-screen tip accurately
shane-kercheval 605db2c
Classify and label record hosts from one table
shane-kercheval bd35679
Wrap the wizard's new prose to fit an 80-column terminal
shane-kercheval b9b06f7
Render human and agent next steps from one classification
shane-kercheval 5cf71d2
Fix remaining overflow in the updated deploy and login messages
shane-kercheval 2acf81a
Tighten the deploy status report's types
shane-kercheval 869b544
Correct two stale claims in the deploy docs
shane-kercheval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| "clerk": patch | ||
| --- | ||
|
|
||
| `clerk deploy` copy fixes: | ||
|
|
||
| - `clerk deploy --help` describes what the bare command does and the JSON report it prints under an agent. | ||
| - The preamble says a hosting provider's generated URL can't be the production domain. | ||
| - The confirmation screen lists all five DNS record hosts, including DKIM, and says DNS records will be needed for them once the instance exists. | ||
| - The DNS check reports records as "not found yet" with a minutes-not-days expectation, tells you what to do based on what's actually pending, and links the Dashboard Domains page for changing the domain. | ||
| - `clerk auth login` prints the claimed app's Dashboard URL; the wizard prints the new production instance's URL and its next steps say the pulled keys go on the host alongside the other Clerk variables. | ||
| - The Google walkthrough adds a tip explaining that the OAuth consent screen's app name is what users see when they sign in, and to choose the name they should see. | ||
| - The DNS check footer points at the "Check again" prompt that follows it instead of telling you to quit and re-run; the closing screen no longer says "Production ready", "sign up at your domain", or "Success" when DNS verification was skipped. | ||
| - Resuming the wizard shows only the DNS records still outstanding, not ones Clerk already verified. When none are outstanding, the DNS screen says what is (the SSL certificate, Clerk finalizing, or a record list Clerk didn't return) instead of a "Configure DNS" page with no records, and the closing screen says "Not yet verified" rather than "DNS pending" so it is right when DNS is done and something else is pending. | ||
| - Each DNS record host is named the same way on every screen, the note about what Clerk manages moved off the rows the user has to add, the Domains-page pointer carries its link, and the closing line says what happens next instead of implying that skipping the check finishes the deploy, and no longer promises an OAuth step on resume when OAuth has already run. | ||
| - Agent-mode `nextAction` tells the agent to add pending DNS records instead of polling, at `complete` says the production keys still have to reach the host, and names OAuth providers the CLI could not configure so an agent doesn't report OAuth as done. Human-mode `clerk deploy status` prints the pending records, never says "ask the user", and resumes with `clerk deploy` rather than a flag that only affects agents. | ||
| - The wizard's new sentences wrap at 76 columns so they stay inside the gutter on an 80-column terminal. The agent JSON report gains a `urls` field with the production instance's Dashboard page and its Domains page. Human-mode `deploy status` now renders its sentence from the same classification of the report as `nextAction` rather than by rewriting that sentence; both read the same as before this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.