Repository navigation
Conversation
Recorded responses live under source/api/src/test/resources/fapi, one directory per response type. The test decodes every file with ClerkApi.json and the registered serializer and lists each file that no longer decodes. The first fixtures are the shapes that broke decoding before: null role and permission descriptions, an enterprise connection without a logo, an RFC 3339 created_at, and an unrecognized invitation status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Collaborator
Author
|
Closing. Hand-written fixtures only guard the four shapes that already broke; they would stay green when FAPI drifts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Four recent fixes (#1027, #1055, #1059, #1064) were for FAPI responses the SDK serializers could not decode. Each fix added its own unit test. This adds one place to keep such response shapes, so the next one is a JSON file and not a new test.
What changed
RecordedResponseDecodingTestdecodes every file undersource/api/src/test/resources/fapi/<type>/withClerkApi.jsonand the serializer registered for that directory. It lists every file that fails. A directory with no registered serializer also fails.created_at, an enterprise connection without a logo, an unknown invitation status, and null role descriptions.Scope
expiredinvitation status is invented.Verification.Statusnames (fix(api): correct swapped Verification.Status serial names #986) or the sessions converter bug (fix(api): decode active sessions from the plain JSON array #1002).Verification
:source:api:testDebugUnitTest --tests RecordedResponseDecodingTeston this branch: 1 test, 0 failures.49d297c4^, before all four fixes: it fails and names each fixture with the decode error its fix addressed.🤖 Generated with Claude Code