Skip to content

ci: run build and unit test workflows on PRs into any branch - #1050

Merged
swolfand merged 2 commits into
mainfrom
sam/ci-run-on-stacked-prs
Oct 6, 2026
Merged

swolfand merged 2 commits into
mainfrom
sam/ci-run-on-stacked-prs

Conversation

@swolfand

@swolfand swolfand commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Build Android App (android.yml) and Android Unit Test (android-test.yml) only ran for PRs into main or sam/clerk-ui. A stacked PR, such as #1019 on top of #1016, never got a build or unit test run until its base merged and it was retargeted to main.

Change

Drop the branches: filter from the pull_request trigger in both workflows, so they run for PRs into any branch. Event types and the draft check are unchanged. Detekt already runs on every PR.

Both workflows also get permissions: contents: read at workflow level, so a PR into any branch runs with a read-only GITHUB_TOKEN. No job needs more: they check out, build or test, and upload artifacts, and artifact uploads and the Gradle cache use the Actions runtime token, not GITHUB_TOKEN.

integration-test.yml stays main-only. It reads the CLERK_INTEGRATION_TEST_PK secret and calls a live Clerk instance. Every stack ends in a PR into main, which still runs it, so running it at each layer would only repeat those live calls.

Overlap

#1021 also edits android-test.yml. It adds a task field and a telemetry entry to the matrix, but does not touch the branches: line, so the two changes should merge cleanly or need only a trivial rebase. #1021 does not change android.yml or integration-test.yml. The new Checks workflow it adds already has no branch filter.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Android checks now run for pull requests targeting any branch, rather than only selected branches.
    • Android workflows now use read-only access to repository contents.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: clerk/clerk-android/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 07184ec9-5c79-4fd3-b948-6d70d77464e2
📥 Commits

Reviewing files that changed from the base of the PR and between 9d7bf87 and f97c28a.

📒 Files selected for processing (2)
  • .github/workflows/android-test.yml
  • .github/workflows/android.yml

Limit details: You’ve used all 6 included reviews currently available. Your 48 included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.


📝 Walkthrough

Walkthrough

Both Android GitHub Actions workflows now allow pull requests targeting any branch. Each workflow also declares read-only contents permissions.

Changes

Android workflow triggers

Layer / File(s) Summary
Update pull request triggers and permissions
.github/workflows/android-test.yml, .github/workflows/android.yml
Both workflows no longer filter pull request triggers by branch. Both declare workflow-level contents: read permissions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to f97c2

Android builds and unit tests will now run for PRs to any target branch. The inspected jobs require only read access, and no actionable merge-blocking risk is apparent.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: build and unit-test workflows will run for pull requests into any branch.
Description check ✅ Passed The description explains why the change is needed and what it changes. It also covers workflow scope and overlap with another pull request. The template’s “What to focus on” and “Screenshots / video” …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@swolfand
swolfand force-pushed the sam/ci-run-on-stacked-prs branch from 9d7bf87 to f97c28a Compare October 6, 2026 18:19
@swolfand
swolfand merged commit fce9e2e into main Oct 6, 2026
9 checks passed
@swolfand
swolfand deleted the sam/ci-run-on-stacked-prs branch October 6, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant