Repository navigation
ci: run build and unit test workflows on PRs into any branch - #1050
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Limit details: You’ve used all 6 included reviews currently available. Your 48 included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour. 📝 WalkthroughWalkthroughBoth Android GitHub Actions workflows now allow pull requests targeting any branch. Each workflow also declares read-only ChangesAndroid workflow triggers
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to Android builds and unit tests will now run for PRs to any target branch. The inspected jobs require only read access, and no actionable merge-blocking risk is apparent. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9d7bf87 to
f97c28a
Compare
Why
Build Android App(android.yml) andAndroid Unit Test(android-test.yml) only ran for PRs intomainorsam/clerk-ui. A stacked PR, such as #1019 on top of #1016, never got a build or unit test run until its base merged and it was retargeted tomain.Change
Drop the
branches:filter from thepull_requesttrigger in both workflows, so they run for PRs into any branch. Event types and the draft check are unchanged. Detekt already runs on every PR.Both workflows also get
permissions: contents: readat workflow level, so a PR into any branch runs with a read-onlyGITHUB_TOKEN. No job needs more: they check out, build or test, and upload artifacts, and artifact uploads and the Gradle cache use the Actions runtime token, notGITHUB_TOKEN.integration-test.ymlstaysmain-only. It reads theCLERK_INTEGRATION_TEST_PKsecret and calls a live Clerk instance. Every stack ends in a PR intomain, which still runs it, so running it at each layer would only repeat those live calls.Overlap
#1021 also edits
android-test.yml. It adds ataskfield and a telemetry entry to the matrix, but does not touch thebranches:line, so the two changes should merge cleanly or need only a trivial rebase. #1021 does not changeandroid.ymlorintegration-test.yml. The newChecksworkflow it adds already has no branch filter.🤖 Generated with Claude Code
Summary by CodeRabbit