Fix off-by-one in force_dry mask indexing - #752
Open
alorentiar wants to merge 1 commit into
Open
alorentiar wants to merge 1 commit into
alorentiar wants to merge 1 commit into
Conversation
qinit.f90 was missing the +1 on the column index, while the filpatch/filval copies had an extra +1 on the row index before the north-edge flip. Make all five sites use the same convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The force_dry lookups were using two different conventions. qinit.f90
was reading one column too far west (no +1 on the column index), while
filpatch/filval in both the shallow and bouss copies were reading one row
too far north (an extra +1 before the north-edge flip). So the mask lands
one cell away from where it was computed, and the wrong cells start dry
or wet.
Made all five sites use the same convention:
Fixes #751.