Add brave as alternative WebSearchTool #245
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { afterEach, describe, expect, mock, test } from 'bun:test' | ||
|
|
||
| let isFirstPartyBaseUrl = true | ||
|
|
||
| mock.module('../adapters/apiAdapter.js', () => ({ | ||
| ApiSearchAdapter: class ApiSearchAdapter {}, | ||
| })) | ||
|
|
||
| mock.module('../adapters/bingAdapter.js', () => ({ | ||
| BingSearchAdapter: class BingSearchAdapter {}, | ||
| })) | ||
|
|
||
| mock.module('../adapters/braveAdapter.js', () => ({ | ||
| BraveSearchAdapter: class BraveSearchAdapter {}, | ||
| })) | ||
|
|
||
| mock.module('../../../utils/model/providers.js', () => ({ | ||
| isFirstPartyAnthropicBaseUrl: () => isFirstPartyBaseUrl, | ||
| })) | ||
|
|
||
| const { createAdapter } = await import('../adapters/index') | ||
|
|
||
| const originalWebSearchAdapter = process.env.WEB_SEARCH_ADAPTER | ||
|
|
||
| afterEach(() => { | ||
| isFirstPartyBaseUrl = true | ||
|
|
||
| if (originalWebSearchAdapter === undefined) { | ||
| delete process.env.WEB_SEARCH_ADAPTER | ||
| } else { | ||
| process.env.WEB_SEARCH_ADAPTER = originalWebSearchAdapter | ||
| } | ||
| }) | ||
|
Comment on lines
+21
to
+33
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: # First, let's look at the test file structure
cat -n src/tools/WebSearchTool/__tests__/adapterFactory.test.tsRepository: claude-code-best/claude-code Length of output: 2631 🏁 Script executed: # Now examine the adapters/index.ts to see the caching mechanism
cat -n src/tools/WebSearchTool/adapters/index.tsRepository: claude-code-best/claude-code Length of output: 1794 🏁 Script executed: # Check what isFirstPartyBaseUrl is and where it's defined
rg -n "isFirstPartyBaseUrl" src/tools/WebSearchTool/ -A 2 -B 2Repository: claude-code-best/claude-code Length of output: 2390 Reset the factory cache between test cases. The module-level 🤖 Prompt for AI Agents |
||
|
|
||
| describe('createAdapter', () => { | ||
| test('reuses the same instance when the selected backend does not change', () => { | ||
| process.env.WEB_SEARCH_ADAPTER = 'brave' | ||
|
|
||
| const firstAdapter = createAdapter() | ||
| const secondAdapter = createAdapter() | ||
|
|
||
| expect(firstAdapter).toBe(secondAdapter) | ||
| expect(firstAdapter.constructor.name).toBe('BraveSearchAdapter') | ||
| }) | ||
|
|
||
| test('rebuilds the adapter when WEB_SEARCH_ADAPTER changes', () => { | ||
| process.env.WEB_SEARCH_ADAPTER = 'brave' | ||
| const braveAdapter = createAdapter() | ||
|
|
||
| process.env.WEB_SEARCH_ADAPTER = 'bing' | ||
| const bingAdapter = createAdapter() | ||
|
|
||
| expect(bingAdapter).not.toBe(braveAdapter) | ||
| expect(bingAdapter.constructor.name).toBe('BingSearchAdapter') | ||
| }) | ||
|
|
||
| test('selects the API adapter for first-party Anthropic URLs', () => { | ||
| delete process.env.WEB_SEARCH_ADAPTER | ||
| isFirstPartyBaseUrl = true | ||
|
|
||
| expect(createAdapter().constructor.name).toBe('ApiSearchAdapter') | ||
| }) | ||
|
|
||
| test('selects the Bing adapter for third-party Anthropic base URLs', () => { | ||
| delete process.env.WEB_SEARCH_ADAPTER | ||
| isFirstPartyBaseUrl = false | ||
|
|
||
| expect(createAdapter().constructor.name).toBe('BingSearchAdapter') | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| import { describe, expect, test } from 'bun:test' | ||
| import { extractBraveResults } from '../adapters/braveAdapter' | ||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Use Switch this relative import to the configured path alias for consistency with project standards. As per coding guidelines, " 🤖 Prompt for AI Agents |
||
|
|
||
| describe('extractBraveResults', () => { | ||
| test('extracts generic grounding results', () => { | ||
| const results = extractBraveResults({ | ||
| grounding: { | ||
| generic: [ | ||
| { | ||
| title: 'Example Title 1', | ||
| url: 'https://example.com/page1', | ||
| snippets: ['First result description'], | ||
| }, | ||
| { | ||
| title: 'Example Title 2', | ||
| url: 'https://example.com/page2', | ||
| snippets: ['Second result description'], | ||
| }, | ||
| ], | ||
| }, | ||
| }) | ||
|
|
||
| expect(results).toEqual([ | ||
| { | ||
| title: 'Example Title 1', | ||
| url: 'https://example.com/page1', | ||
| snippet: 'First result description', | ||
| }, | ||
| { | ||
| title: 'Example Title 2', | ||
| url: 'https://example.com/page2', | ||
| snippet: 'Second result description', | ||
| }, | ||
| ]) | ||
| }) | ||
|
|
||
| test('combines generic, poi, and map grounding results', () => { | ||
| const results = extractBraveResults({ | ||
| grounding: { | ||
| generic: [{ title: 'Generic', url: 'https://example.com/generic' }], | ||
| poi: { title: 'POI', url: 'https://maps.example.com/poi' }, | ||
| map: [{ title: 'Map', url: 'https://maps.example.com/map' }], | ||
| }, | ||
| }) | ||
|
|
||
| expect(results).toEqual([ | ||
| { title: 'Generic', url: 'https://example.com/generic', snippet: undefined }, | ||
| { title: 'POI', url: 'https://maps.example.com/poi', snippet: undefined }, | ||
| { title: 'Map', url: 'https://maps.example.com/map', snippet: undefined }, | ||
| ]) | ||
| }) | ||
|
|
||
| test('joins multiple snippets into one summary string', () => { | ||
| const results = extractBraveResults({ | ||
| grounding: { | ||
| generic: [ | ||
| { | ||
| title: 'Joined Snippets', | ||
| url: 'https://example.com/joined', | ||
| snippets: ['First snippet.', 'Second snippet.'], | ||
| }, | ||
| ], | ||
| }, | ||
| }) | ||
|
|
||
| expect(results[0].snippet).toBe('First snippet. Second snippet.') | ||
| }) | ||
|
|
||
| test('skips entries without a title or URL', () => { | ||
| const results = extractBraveResults({ | ||
| grounding: { | ||
| generic: [ | ||
| { title: 'Missing URL' }, | ||
| { url: 'https://example.com/missing-title' }, | ||
| { title: 'Valid', url: 'https://example.com/valid' }, | ||
| ], | ||
| }, | ||
| }) | ||
|
|
||
| expect(results).toEqual([ | ||
| { title: 'Valid', url: 'https://example.com/valid', snippet: undefined }, | ||
| ]) | ||
| }) | ||
|
|
||
| test('deduplicates repeated URLs across grounding buckets', () => { | ||
| const results = extractBraveResults({ | ||
| grounding: { | ||
| generic: [{ title: 'First', url: 'https://example.com/dup' }], | ||
| poi: { title: 'Second', url: 'https://example.com/dup' }, | ||
| map: [{ title: 'Third', url: 'https://example.com/dup' }], | ||
| }, | ||
| }) | ||
|
|
||
| expect(results).toEqual([ | ||
| { title: 'First', url: 'https://example.com/dup', snippet: undefined }, | ||
| ]) | ||
| }) | ||
|
|
||
| test('returns empty array when grounding is missing', () => { | ||
| expect(extractBraveResults({})).toEqual([]) | ||
| }) | ||
|
|
||
| test('returns empty array when grounding arrays are absent', () => { | ||
| expect(extractBraveResults({ grounding: {} })).toEqual([]) | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.