Repository navigation
Spring cache with Caffeine and micrometer measurements - #448
Conversation
…ons and push data to a statsd host.
⛔ Snyk checks have failed. 48 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
twagoo
left a comment
There was a problem hiding this comment.
It looks good! I have no experience with Micrometer, but I saw in the documentation that it has a few annotations. I wonder about @Timed in particular, and whether it could be used to make the timing in the SolrDaoImpl and its children a bit more declarative and clean. If not, I think this is perfectly accessible.
|
Thanks! I looked a bit at I wanted to manage this PR - I wanted to test the whole setup locally before, to see if the grafana and graphite pick everything correctly. I'll merge it after my checks I wanted to do. |
Added Caffeine cache as a replacement to our guava wrapped implementation.
Additionally added micrometer and configured sending measurements for tagged solr queries and cache stats.
Addresses also #157