Clamp reads to not overrun the remaining size of the ISO. - #184
Merged
Conversation
Many of the values on an ISO are 32-bit values that could be manipulated or otherwise be bogus. If that happened, we could erroneously allocate a large buffer and attempt to read past the end of the ISO. While this would only be a virtual memory allocation in the default Linux setup, there is no reason to allow allocating beyond the end of the ISO itself. Add in a new read_clamped helper which will return a short read if the read would go past the end of the ISO. Also add in tests. Reported by, and initial fix proposed by: mohammad adnan (cystack.ps redteam) Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/clamp-reads
branch
from
August 24, 2026 23:04
18110f4 to
74983c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the values on an ISO are 32-bit values that could be manipulated or otherwise be bogus. If that happened, we could erroneously allocate a large buffer and attempt to read past the end of the ISO. While this would only be a virtual memory allocation in the default Linux setup, there is no reason to allow allocating beyond the end of the ISO itself. Add in a new read_clamped helper which will return a short read if the read would go past the end of the ISO. Also add in tests.
Reported by, and initial fix proposed by: mohammad adnan (cystack.ps redteam)
Fixes #182