Fix various issues pointed out by review. - #181
Merged
Conversation
Basically we remove tons of redundant seeks in the method based on the observation that this always writes out consecutive data. By getting rid of these syscalls we greatly improve performance of this method. Also add in tests to make sure that this still works. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
We were getting an index error earlier because we were calculating the end *before* the loop. Fix this and add a test. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Otherwise trying to reshuffle the extents would fail since it wouldn't find an attached Inode object. Also add in tests. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.