Increase test coverage - #179
Merged
Merged
Conversation
Use the "python3 -m <module>" idiom everywhere, which makes this more portable. Also remove the lineprof target which requires a package which is not packaged on modern Linux distributions. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
There were 2 bugs here: 1. In the low-level inode.py, if there was an extent that both didn't have an original extent (because it was new), and didn't have a new extent (because it hadn't been assigned one via reshuffle_extents yet), it would throw an IndexError. In practice this should never happen, but if there is a bug at the upper layer we shouldn't propagate an IndexError. Detect the situation and report it. 2. The real bug is that get_file_byte_extents() with a new ISO needs to reshuffle_extents before doing work so that every file/directory has an extent assigned. Do that here. Also add in tests for both of the above. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
And remove a Python 2 leftover. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests increase out test coverage up to 98% .