Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
packages/ckeditor5-dev-release-tools/tests/tasks/cleanuppackages.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-dev-translations/tests/utils/synchronizetranslationsbasedoncontext.js
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Bumped vitest.
💡 Additional information
Coverage fell due to vitest changing method of calculating coverage.
Note
Medium Risk
Tooling-only change, but it touches the entire test/coverage stack and could cause widespread CI/test failures or coverage deltas due to Vitest v4 behavior changes.
Overview
Upgrades the repo-wide test runner from
vitestv3 to v4 (and@vitest/coverage-v8), updating the lockfile accordingly.Standardizes Vitest configs across packages by enabling stricter mock cleanup (
clearMocks,mockReset,unstubEnvs,unstubGlobalswith a few package-specific exceptions) and adjusting coverage settings (including new excludes and droppingcoverage.allwhere it was set).Updates a handful of tests/utilities to remain compatible with Vitest v4 mocking semantics, including making
mockGetUserDependency()idempotent, removing manual cleanup hooks now handled by config, tightening assertions, and providing an explicitwebpackmock implementation.Written by Cursor Bugbot for commit fb20326. This will update automatically on new commits. Configure here.