Repository navigation
Revert "Remove greedy regexes all together, no idea what they origina… - #356
Merged
Merged
Conversation
…lly were trying to do" This reverts commit a1f77d1. Regex were not greedy, but rather the regex was matching XML declarations starting with "<?xml". This had downstream effects when calling `etree.fromstring` since the XML string was already `str`/Unicode and encoding declarations in the XML declaration would cause that function to fail and throw an exception.
Contributor
Author
|
For context, was initially receiving errors like this on some harvest objects that had XML declarations that declared an encoding: |
Contributor
Author
|
I think that the call to |
Member
|
Not sure what is going on with the 2.10 tests but it is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lly were trying to do"
This reverts commit a1f77d1.
Regex were not greedy, but rather the regex was matching XML declarations starting with "<?xml". This had downstream effects when calling
etree.fromstringsince the XML string was alreadystr/Unicode and encoding declarations in the XML declaration would cause that function to fail and throw an exception.