Skip to content

feat(frontend): kanban column expansion + note-stack task detail viewer; chore(nix): trunk 0.22.1 - #187

Merged
ck3mp3r merged 8 commits into
mainfrom
feat/task-detail-two-pane
Nov 6, 2026
Merged

ck3mp3r merged 8 commits into
mainfrom
feat/task-detail-two-pane

Conversation

@ck3mp3r

@ck3mp3r ck3mp3r commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Summary

Three stacked changes on top of main, plus a nix toolchain bump.

Kanban board — per-column expand (≥1280px)

  • Each column has an expand toggle at ≥1280px: the grid switches to a 4fr/1fr template and one column at a time takes the wide slot, marked with a ring.
  • Re-clicking the toggle resets the layout; expanding does not jump the layout, and cards reflow inside the expanded column.
  • Desktop-only; both render surfaces (board and column) behave the same.

Task detail viewer — 95vw note-stack two-pane popup

  • TaskDetailDialog is now a 95vw two-pane popup, no routing.
  • Left pane: the entry task as the first standard TaskCard row, followed by child rows. Selection drives the right pane through a reactive data-selected highlight.
  • No back button; one level of nesting per note-stack reference.
  • initial_open_subtask_id opens that subtask as the current one; closing the dialog or switching task re-bootstraps the stack.
  • Fetch errors surface as red error blocks and recover on the next selection; below 1024px the two panes stack vertically.

Refactor — pure one-task detail pane

  • TaskDetailContent is a pure one-task pane; the SubtaskStack accordion and SubtaskStackItem are removed.
  • Public props and the KanbanColumn call site are byte-unchanged.

nix — vendored trunk 0.22.1

  • nixpkgs-unstable still ships trunk 0.21.14, so 0.22.1 comes from a vendored derivation (nix/trunk.nix) wired in through a flake.nix overlay. The same overlay feeds the dev shell and the release frontend build.
  • Trunk.toml, nix/dev.nix and nix/packaging.nix are untouched; the tailwind pre_build hook still produces a byte-identical crates/context-frontend/src/public/style.css.
  • Temporary state: once nixpkgs ships ≥ 0.22.1, delete the overlay and nix/trunk.nix and let nix flake update restore upstream pkgs.trunk.

Verification

  • Every round was machine-checked by the reviewer: cargo fmt, cargo clippy, trunk build --release, deterministic dist regeneration. Evidence notes: 5aa15915, 5c46dc45, 5a387830, 7eef0fa4, 42389bec, 41ef3f3b, 7aadbf61.
  • trunk upgrade on the final branch: nix develop -c trunk --version prints trunk 0.22.1; git diff -- nix/dev.nix nix/packaging.nix Trunk.toml is empty; the 0.21.14 vs 0.22.1 hook canary (style.css) is byte-identical (cmp exit 0, git diff empty); cargo build --release -p context-server succeeds on the 0.22.1-produced dist.
  • A residual manual browser walkthrough is noted in each task.

c5t

Tasks 61c60c2c, 6d81d823, 7b6b973d, 778deb6e, 46b478bf under parent 7694d6ac (list 513cfb12).

One kanban column expands to 4fr while the other five compact to 1fr at 1280px and wider, driven by an inline --kanban-grid-cols property and one unlayered rule in input.css.

Re-clicking the expanded column toggle is the reset path: a separate reset control needed a conditionally rendered element above the grid and made the board jump vertically.

Toggles are hidden below the 1280px breakpoint and the expanded column carries a ring marker. Task cards keep filling their column with no width constraints.
The two-pane task dialog renders child tasks in its own left pane, so
TaskDetailContent must stop owning subtask navigation: remove the
subtask fetch effect, the SubtaskStack accordion, the SubtaskStackItem
component and the initial_open_subtask_id prop.

TaskDetailDialog keeps its initial_open_subtask_id prop (unused until
the two-pane shell lands) so its signature and the KanbanColumn call
site stay untouched. Until then the dialog shows no children, which is
the intended interim state.
A card click opened a single-column dialog that showed only the selected
task; child subtasks sat behind an accordion that could not navigate
deeper. The dialog is now a 95vw split surface: the left pane lists the
current task's children as TaskCard rows, the right pane renders
TaskDetailContent, and activating a child drills down by pushing it onto
a root-first path signal. The path bar offers a back control and
per-entry truncation, so any depth is reachable without a route change.

The bootstrap fetch walks parent_id upward, so a subtask opened from the
board through initial_open_subtask_id arrives with its ancestor chain
already in the path. Closing the dialog or changing task_id rebuilds the
path from scratch, leaving no stale entries.
User review of the drill-down build picked the note stack view as the
literal model: no back button, the active selection drives the right
pane, and the left pane never re-roots. The path/history signal, path bar
and back control are gone; in their place a single selected_task_id
RwSignal is re-bootstrapped on every open (initial subtask when present,
else the entry task).

The left pane now anchors on task_id: it pins the entry task card above
indented child rows and fetches all direct children in one call. Cards
carry data-task-id plus a reactively bound data-selected attribute backed
by .task-stack-card rules cloned from .note-stack-card, so the highlight
matches the note stack instead of the old DOM helper. A child's own
children stay unreachable, the same one-level limit the note stack has.
Round-2 review rejected the bespoke preview card: in the note stack the
first row is just another row, so the entry task now uses the same
TaskCard as its children and differs only by the missing ml-2 indent.
The anchor-only styling is gone (150-char description truncation, tag
chips, fixed padding, separate click handler); .task-stack-card stays as
the uniform selected-state styling shared by every row, and each row
wrapper now carries cursor-pointer for the hover affordance.

Also drop the .task-detail-dialog-surface .thaw-dialog-content rule: the
dialog no longer renders DialogContent, so the rule can never match. The
surface and body rules stay.
The selection Effect kept only the Ok branch, so a failed tasks::get left
the right pane stuck on "Loading..." forever, and the entry fetch dropped
its error the same way. Both signals now hold Option<Result<Task,
ApiClientError>> and the view matches on them, rendering the shared red
error block (TaskListContent styling, note_detail.rs Result shape) with
the API error text. A later successful selection replaces the error
without closing the dialog. The children fetch keeps its lenient
empty-list behaviour, so a failed child load still reads "No subtasks".
thaw 0.5.0-beta ships .thaw-dialog-surface with height: fit-content, and
the override only capped the surface at max-height: 90vh. The height
therefore still followed content up to the cap, so the dialog jumped and
grew as different tasks were selected.

Set height: 90vh directly on .task-detail-dialog-surface and drop the
max-h-[90vh] utility from the DialogSurface class so input.css is the
sole height source. Give the main pane min-height: 0 and make the
below-1024px stacked side pane a fixed 40vh, so both panes scroll
internally instead of pushing the box. The dialog now replicates the
note-detail pattern: viewport-fixed height, min-h-0 scroll panes.
@ck3mp3r
ck3mp3r merged commit 1a76afc into main Nov 6, 2026
2 checks passed
@ck3mp3r
ck3mp3r deleted the feat/task-detail-two-pane branch November 6, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant