fix(kubernetes): block metrics-server install on Talos clusters#594
Merged
Conversation
The marketplace metrics-server is only enabled for k3s clusters, so installing it on a Talos cluster silently reports success without actually installing anything. Validate the resolved canonical app name after checkAppPlan (which resolves partial matches like "metrics" -> "metrics-server") and exit early when the app is unsupported on the target cluster type. Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Member
Author
Manual verificationConfirmed the behavior against real clusters. Talos cluster — blocked with a clear error: k3s cluster — installs as before: Talos cluster — other applications still install fine (no regression): Only |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
hlts2
commented
Jun 22, 2026
jokestax
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
Problem
When adding a marketplace app to a Talos cluster, the CLI reports a successful install even though nothing is actually installed:
The marketplace
metrics-serveris only enabled for k3s clusters (https://github.com/civo/kubernetes-marketplace/blob/master/metrics-server/manifest.yaml), so the user has no way to know the install silently did nothing.Scope
Only
metrics-serveris blocked on Talos. Other marketplace apps install fine on Talos clusters, so blocking all apps (as explored in #593) would be too broad. On Talos, metrics-server must be installed separately (https://docs.siderolabs.com/kubernetes-guides/monitoring-and-observability/deploy-metrics-server).Fix
checkAppPlannow also returns the index of the resolved app, so validation runs against the canonical app name rather than raw user input. This closes the partial-match bypass (e.g.metricsresolves tometrics-serverviastrings.Contains).RequestedSplitexits early with a clear message when the resolved app is unsupported on the target cluster type.unsupportedAppsByClusterTypetable with a TODO to remove it oncecluster_typeis surfaced through the API/civogo.Tests
isAppCompatibleWithClusterType.Supersedes #593.