fix(docs): Correct README clone URL to circlefin/arc-escrow#16
Open
Sertug17 wants to merge 1 commit into
Open
Conversation
The clone command in the README references the original internal repository name (akelani-circle/workflow-escrow-refund-protocol), which returns 404. The correct public repository is circlefin/arc-escrow. Same pattern was identified in arc-fintech README in PR circlefin/arc-fintech#9.
4706813 to
39cd354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README's "Getting Started" section uses an internal repository name
in the clone command, which returns 404 for new contributors:
git clone git@github.com:akelani-circle/workflow-escrow-refund-protocol.git cd workflow-escrow-refund-protocolThe correct public repository is
circlefin/arc-escrow. This blocksthe entire setup flow on the very first step.
Change
Verification
Related
The same
akelani-circle/...pattern also appeared inarc-fintechand wasaddressed in arc-fintech#9
by @skyc1e. This PR applies the same fix to
arc-escrow.Notes
cd).akelani-circle-patch-1branch ("Workflow Escrow Refund Protocol" →"Arc Escrow"); this PR is independent and only fixes the broken clone URL.