Repository navigation
fix(doppler): reuse the doppler cli for authentication - #4
Merged
Merged
Conversation
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 3 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Reuse the CLI's directory-scoped identity for HTTPS secret reads and keep explicit DOPPLER_TOKEN support for unattended environments. Remove native browser authorization, OS credential adapters and their CI setup. Document standard CLI locations, migration and the existing development audit blocker. Migration: remove resenv login/logout and stop reading resenv-managed OS credentials. Run doppler login in the application directory or supply DOPPLER_TOKEN before starting the application.
Update the matching Vitest runner and coverage provider to 4.1.12 and the separately installed Undici copies to patched releases. Preserve unrelated locked versions and record the remaining bundled npm audit blockers without expanding exceptions.
Keep the two official standalone plugins and omit their unused engine peer so npm publisher bundles are not installed. Enforce absence before auditing and planning, retain import and braces guards, and document the existing review deadline without adding exceptions.
titan-ron
force-pushed
the
titan/reuse-doppler-cli-auth
branch
from
October 24, 2026 23:40
1573322 to
d413bc1
Compare
titan-ron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Delegate Doppler login, logout and token storage to the official Doppler CLI. At startup, resenv uses an explicit
DOPPLER_TOKENor reads the CLI identity selected by the application's working directory, then fetches only referenced secrets through HTTPS. CLI discovery covers standard macOS/Linux paths and default per-user WinGet/Scoop installations. Credential lookup retains fixed executable paths, captured output, a restricted environment and startup limits.Beta migration: remove
resenv login/logout, native browser authorization and direct OS credential-store adapters. Usedoppler login/logoutinstead. Earlier resenv-managed credentials are ignored; the migration guide explains cleanup. Explicit tokens still support unattended runs without the CLI. Reference syntax, Node support, literal fetched values and atomic environment updates are unchanged.Patch Vitest/coverage to 4.1.12 and the separately installed Undici copies. Remove the unused full release engine from direct dependencies and omit its inferred peer installation. Audit and release planning enforce the absence of the engine and publisher modules while retaining the two official analysis/notes plugins. No advisory exception or expiry is expanded; the existing November 9 platform review deadline remains.
Keep documentation focused on current contracts, tool choices and release procedures. Remove four historical audit/validation reports, condense dependency/security/maintainer guidance, fix stale build guidance and links, and keep per-run evidence in PRs and CI. The executable advisory policy, expiry and publisher guards are unchanged.
Known limits:
npm lsreports the deliberately omitted engine peers. Their graph remains in the lockfile, so explicitly including uninstalled peers in an audit can still report those advisories. Guards prevent these modules from being restored to the installed planner.Validation
Clean
npm cion pinned Node 24.19.0.npm run audit: zero reported vulnerabilities in installed runtime/development dependencies.npm audit signatures: 215 verified registry signatures and 69 attestations.npm run verify: lint, strict implementation/spec types, build, 94 unit/tooling tests, coverage gate, 43 process tests, 16 packed runtime checks and two typed consumers passed.Authentication tests use dummy CLI executables and mocked provider calls; no developer credentials or OS credential-store entries are used.
Documentation links and retained files checked in both source and generated distribution; final archive rebuilt and package checks rerun after the documentation edits.