-
Notifications
You must be signed in to change notification settings - Fork 5
fix(cli): stash init --drizzle installs EQL v3, not v2 #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| 'stash': patch | ||
| --- | ||
|
|
||
| `stash init --drizzle` now installs EQL v3 instead of v2. | ||
|
|
||
| The Drizzle init flow pinned `--eql-version 2`, because `stash eql install | ||
| --drizzle` (the only migration-generating install path at the time) was | ||
| v2-only. That made `stash init --drizzle` the single flow that provisioned a v2 | ||
| database — a bare `stash eql install`, and init for every other integration, | ||
| already defaulted to v3. It also contradicted the `stash-drizzle` skill init | ||
| copies into the same project, which documents the v3 `@cipherstash/stack-drizzle/v3` | ||
| surface (`types.*` domains, `EncryptionV3`) and would have the user's agent | ||
| author v3 code against a v2 database. | ||
|
|
||
| Init's Drizzle flow now routes through `stash eql migration --drizzle`, so it | ||
| stays migration-first (the install lands in your Drizzle migration history and | ||
| ships to every environment via `drizzle-kit migrate`) while emitting v3 SQL. | ||
| The generated migration also carries the `cs_migrations` tracking schema, so one | ||
| `drizzle-kit migrate` covers everything `stash encrypt …` needs. If `drizzle-kit` | ||
| isn't installed or configured, init now reports EQL as not installed and points | ||
| at `stash eql migration --drizzle` rather than aborting the run. | ||
|
|
||
| The v2 Drizzle path remains available for existing deployments via an explicit | ||
| `stash eql install --drizzle --eql-version 2`; that command's error message now | ||
| points at the v3 alternative instead of only suggesting `--eql-version 2`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.