xlstream-eval: fix COUNTIF/SUMIF with "=value" criteria returning 0#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #141
Problem
COUNTIF(A2:A6,"=yes")returns 0 instead of 3. Excel supports"=value"as criteria syntax meaning "equals value". Affects SUMIF, AVERAGEIF, COUNTIFS, SUMIFS, AVERAGEIFS, MINIFS, MAXIFS.Fix
Two root causes:
extract_static_criteriapasses the raw"=yes"string as the composite key, but the prelude stores cell values without the=prefix (e.g."yes"), so the direct hash lookup misses.try_operator_criteriaearly-returnsNonewhen all criteria areEquals, preventing the fallback scan from matching.Changes
multi_conditional.rs: strip leading=inextract_static_criteriaso composite keys match prelude entriesprelude.rs: remove the all-Equals guard fromtry_operator_criteria(now always returnsValue, notOption<Value>)prelude.rs: simplifyget_multi_conditionalcall site (noOptionunwrap needed)Test plan
"=value", plain"value", numeric"=10", and mixed criteriacargo test -p xlstream-eval --test conformancepasses (85 tests, 0 failures)cargo test -p xlstream-evalpasses (no regressions)make checkpassesCloses #141