xlstream-eval: replace handler wrappers with Dispatch enum#183
Merged
Conversation
- add Dispatch enum (Eager/Aggregate/Custom) to FunctionEntry - delete 134 boilerplate handle_* wrappers from builtins/mod.rs - aggregate functions return Value directly (not Result) - 7 statistical functions return Value directly (not Result) - update subtotal.rs and test callers
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: f3adae0 | Previous: a79fc8a | Ratio |
|---|---|---|---|
date/datedif |
669 ns/iter (± 10) |
534 ns/iter (± 15) |
1.25 |
math/int |
119 ns/iter (± 3) |
92 ns/iter (± 0) |
1.29 |
string/textjoin |
341 ns/iter (± 32) |
281 ns/iter (± 6) |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
- remove stale # Errors rustdoc from 10 aggregate fns (now return Value) - remove stale # Errors rustdoc from 7 statistical fns (now return Value) - convert 7 statistical wrappers to Dispatch::Eager, delete handle_* fns - update spec to reflect direct return-type changes (no _as_value wrappers) - add agg_kind_implies_dispatch_aggregate registry invariant test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispatchenum (Eager/Aggregate/Custom) toFunctionEntry, replacing theHandlertype aliashandle_*wrappers frombuiltins/mod.rs(-784 lines net)sum,count, etc.) returnValuedirectly instead ofResult<Value, CellError>builtin_poisson_dist,builtin_binom_dist, etc.) returnValuedirectlydocs/roadmap/v0.4/03-eval-mode-dispatch.mdStacked on #182. Do not merge until #182 merges. Rebase if #182 changes.
Test plan
make checkpasses (fmt, clippy, test, doctest)