Tooling in scaffold skill, commit-per-task law, Task 1 opens with add-data-source - #3
Merged
Merged
Conversation
… with add-data-source Aligns the harness with the confirmed live run-through (3 setup skills, then 4 build-verify tasks). - scaffold-code-app skill (both mirrored copies): new step 5 sets up the quality tooling (Vitest + RTL + jsdom, ESLint + react-hooks, the `npm run verify` script) so the gate works before Task 1; push step renumbered to 6. - AGENTS.md: new Architect-mode law to commit each task once its gate is green, one task per commit. The git log becomes the build record. - task-1-data-layer.md: opens by running dataverse-add-data-source (no longer a separate setup skill); the smoke-test bullet now assumes the runner was set up by scaffold-code-app. - DEMO-PLAN.md: rewritten as the confirmed run sheet (setup skills, task loop, deploy, teaching points, dry-run risks). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the repo’s “harness” documentation and skill guidance to match a live run-through flow: 3 setup skills (including scaffolding quality tooling) followed by 4 build/verify tasks, with Task 1 starting by adding Dataverse data sources and each task committed after a green verify gate.
Changes:
- Adds a new “quality tooling” step to the
scaffold-code-appskill sonpm run verifyis available before Task 1. - Introduces an Architect-mode rule to commit after each task’s green gate, one task per commit.
- Adjusts Task 1 to begin by running
dataverse-add-data-sourceand updates the demo run sheet to the new end-to-end flow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/tasks/task-1-data-layer.md | Adds “Start here” guidance to run add-data-source at the beginning of Task 1 and clarifies tooling expectations. |
| DEMO-PLAN.md | Expands from a short list into a full demo run sheet (setup → task loop → deploy → teaching points → risks). |
| AGENTS.md | Adds “commit per task once gate is green” as an Architect-mode law. |
| .claude/skills/scaffold-code-app/SKILL.md | Adds a new step to set up testing/linting/verify scripts before feature work; renumbers push step. |
| .agents/skills/scaffold-code-app/SKILL.md | Same as .claude/ mirror: adds tooling step and renumbers push step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| **Goal:** the two Dataverse tables become typed data sources the app can read and write; no UI yet. | ||
|
|
||
| > **Start here:** run the `dataverse-add-data-source` skill to add `eppc_session` then `eppc_feedback` |
|
|
||
| ### Deploy + the live proof | ||
|
|
||
| - `npm run build`, then `power-apps push` into the same solution. |
Comment on lines
+91
to
+93
| See **AGENTS.md (repo root) → Stack notes** for the exact pins. After this, `npm run verify` runs | ||
| clean on the empty app, so the first task gate (Task 1) has a working harness to run against rather | ||
| than being set up live. |
Comment on lines
+91
to
+93
| See **AGENTS.md (repo root) → Stack notes** for the exact pins. After this, `npm run verify` runs | ||
| clean on the empty app, so the first task gate (Task 1) has a working harness to run against rather | ||
| than being set up live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the harness with the confirmed live run-through: 3 setup skills, then 4 build-verify tasks (no separate
dataverse-add-data-sourcestep). Two of the changes answer "shouldn't the AI do that?" — yes, and now the harness directs it to.Changes
scaffold-code-appskill (both.agentsand.claudemirrors) — new step 5: set up the quality tooling (Vitest + RTL + jsdom, ESLint + typescript-eslint + react-hooks, thenpm run verifyscript). This makes the app verifiable before Task 1's gate runs, instead of Task 1 having to configure tooling live. Push step renumbered to 6.AGENTS.md— new Architect-mode law: commit each task once its gate is green, one task per commit. The AI commits, directed by the harness; the git log becomes a live "I directed it" artifact you can scroll on stage.specs/tasks/task-1-data-layer.md— Task 1 now opens by runningdataverse-add-data-source(it is the first build task, not a fourth setup skill), and the smoke-test bullet assumes the runner was already set up byscaffold-code-app.DEMO-PLAN.md— rewritten from the old 4-line skill list into the full run sheet: setup skills → task loop → deploy → teaching points → dry-run risks.The run-through this encodes
Setup:
/dataverse-scaffold-tables→/dataverse-create-records→/scaffold-code-appBuild: Complete Task 1 → 2 → 3 → 4 (each: read AGENTS.md + task, build,
npm run verify, commit when green, stop)Deploy:
npm run build→power-apps push→ live sign-in + real write.Note for maintenance
The skills are mirrored in
.agents/skills/and.claude/skills/; this PR keeps both identical. Any future skill edit has to touch both or they drift.🤖 Generated with Claude Code