Skip to content

ci: bump Actions off Node 20 runtime (#6) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chtnnh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: bump Actions off Node 20 runtime (#6) #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a8120
ci: bump Actions off Node 20 runtime (#6)
chtnnh Aug 13, 2026
610ee6b
Merge branch 'main' into fix/gh-actions-node24-bump
chtnnh Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
with:
node-version: "22"
cache: npm
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: actions/setup-node@v4
- uses: actions/setup-node@v5
with:
node-version: "22"
cache: npm
Expand All @@ -38,9 +38,11 @@ jobs:
npm run build -w website

- name: Upload Pages artifact
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@v5
with:
path: website/build
# v4+ excludes dotfiles by default; Docusaurus needs .nojekyll.
include-hidden-files: true

deploy:
needs: build
Expand All @@ -50,4 +52,4 @@ jobs:
url: ${{ steps.deployment.outputs.page_url }}
steps:
- id: deployment
uses: actions/deploy-pages@v4
uses: actions/deploy-pages@v5
4 changes: 2 additions & 2 deletions .github/workflows/know-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ jobs:
verify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
fetch-depth: 0
# Default pull_request checkout is a merge commit (no trailers).
# Verify must run on the PR tip that carries Know-Code-Verified.
ref: ${{ github.event.pull_request.head.sha }}

- uses: actions/setup-node@v4
- uses: actions/setup-node@v5
with:
node-version: "22"
cache: npm
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:
runs-on: ubuntu-latest
environment: npm-release
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

# Node 24 → npm ≥ 11.5.1 (required for trusted publishing).
# Do NOT set registry-url: setup-node would inject a dummy NODE_AUTH_TOKEN
# that prevents the OIDC exchange (ENEEDAUTH).
- uses: actions/setup-node@v4
- uses: actions/setup-node@v5
with:
node-version: "24"
package-manager-cache: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/umami-proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Deploy Worker
uses: cloudflare/wrangler-action@v4
Expand Down
2 changes: 1 addition & 1 deletion action/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ runs:
using: composite
steps:
- name: Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
Comment thread
cursor[bot] marked this conversation as resolved.
with:
node-version: "22"

Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/commands-core.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ describe("commands: config / init / quiz / doctor / reset / ship", () => {
const yml = consumerWorkflowYaml("develop");
assert.match(yml, /base-branch: develop/);
assert.match(yml, /chtnnh\/know-code\/action@v0\.3\.0/);
assert.match(yml, /actions\/checkout@v5/);
// Push-to-base has no merge-base ahead of HEAD — verify must be PR-only.
assert.match(yml, /pull_request:/);
assert.doesNotMatch(yml, /push:/);
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
verify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
fetch-depth: 0
ref: \${{ github.event.pull_request.head.sha }}
Expand Down
2 changes: 1 addition & 1 deletion website/docs/ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
verify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
Expand Down
Loading