Repository navigation
Add HEVC extension buffer wrappers, zero-init decode buffers, expose Display::handle - #40
Open
andreytkachenko wants to merge 2 commits into
Open
andreytkachenko wants to merge 2 commits into
andreytkachenko wants to merge 2 commits into
Conversation
…uctors Two changes needed by VAAPI decoders targeting Intel iHD: 1. PictureParameterBufferHEVCExtension / SliceParameterBufferHEVCExtension wrappers over the *Extension FFI structs (base + rext, scc zeroed), plus PictureParameter::HEVCExtension / SliceParameter::HEVCExtension enum variants. For REXT/SCC profiles (sps profile_idc >= 4) the driver expects the full extension-size buffer attached as a plain picture/slice parameter type, matching FFmpeg vaapi_hevc.c. 2. Zero-initialize VAPictureParameterBufferH264, VASliceParameterBufferH264, VASliceParameterBufferHEVC, VASliceParameterBufferHEVCRext and VADecPictureParameterBufferVP9 constructors instead of using struct literals: Rust struct literals leave implicit C padding bytes uninitialized, and iHD compares the whole mapped buffer byte-wise against FFmpeg's memset-zeroed buffers. Uninitialized padding leaked garbage to the driver.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes needed by VAAPI video decoders targeting the Intel iHD driver:
Expose
Display::handle— allow obtaining the rawVADisplayfor direct libva FFI use.HEVC extension buffer wrappers + zero-initialized decode parameter buffers:
PictureParameterBufferHEVCExtension/SliceParameterBufferHEVCExtensionwrappers over the*ExtensionFFI structs (base + rext, scc zeroed), plusPictureParameter::HEVCExtension/SliceParameter::HEVCExtensionenum variants. For REXT/SCC profiles (sps profile_idc >= 4) the driver expects the full extension-size buffer attached as a plain picture/slice parameter type, matching FFmpegvaapi_hevc.c.VAPictureParameterBufferH264,VASliceParameterBufferH264,VASliceParameterBufferHEVC,VASliceParameterBufferHEVCRextandVADecPictureParameterBufferVP9constructors instead of using struct literals: Rust struct literals leave implicit C padding bytes uninitialized, and iHD compares the whole mapped buffer byte-wise against FFmpeg's memset-zeroed buffers — uninitialized padding leaked garbage to the driver.Used by the vacc VAAPI decoders. Interim until this merges and is released, the fork is published to crates.io as
vacc-libva.