Repository navigation
Know the visualizer and update options in the stand-in daemon - #25
Merged
Merged
Conversation
dev/fakedaemon dropped the options it did not know. Since the window keeps its large visualizer in viz_full, the stand-in answered every change without it and the window closed the visualizer again, so dev/bench's visualizer column and dev/screenshot with f showed the player view. dev_builds is added as well, so the stand-in keeps every option the daemon has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev/fakedaemon dropped options it did not know. The window keeps its large visualizer in
viz_full(since 56dfa1e), so the stand-in answered each change without it and the window closed the visualizer again:dev/bench's "visualizer" column measured the player view (5.6 % · 60 fps, the same as "playing"); with this change it measures the large visualizer (2.2 % · 30 fps).dev/screenshot out.png fshowed the player instead of the visualizer.dev_builds(#23) is added too, so the stand-in has every optionconfig::Optionshas.Checked:
go -C dev test ./...,dev/bench,dev/screenshot … f.🤖 Generated with Claude Code