Skip to content

fix(pr-review-fixer): add gh-missing fallback via mcp__github__ tools - #5

Merged
chiptus merged 2 commits into
mainfrom
claude/upline-pr-503-review-0hr7uj
Sep 18, 2026
Merged

chiptus merged 2 commits into
mainfrom
claude/upline-pr-503-review-0hr7uj

Conversation

@chiptus

@chiptus chiptus commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Ports chiptus/UpLine#503 into this repo's copy of pr-review-fixer: gh isn't installed in remote/cloud sessions (GitHub access there goes through mcp__github__* tools instead), so the skill hard-failed on command not found. Adds a gh-availability check and an MCP-based fallback path for fetch/resolve/reply, disclosed to its own gh-missing.md (only loaded when gh turns out to be missing) rather than inlined for every reader. Already includes the dedup fix applied as a follow-up on mattpocock#503 (dropped a sentence duplicated between SKILL.md and gh-missing.md).

Verification

  • claude plugin validate . --strict passes.
  • gh-missing path: read through gh-missing.md against mcp__github__pull_request_read's actual response shape (get_review_comments/get_reviews/get_comments) to confirm the reconstructed {threads, reviews, issueComments} matches what Phase 2+ expects.
  • gh-available path is unchanged (original script calls untouched).
  • No em-dashes introduced (repo convention); re-wrote all copied prose with commas/colons/parens instead of doing a blind character substitution.

🤖 Generated with Claude Code

https://claude.ai/code/session_01776GRzBiT1RkWHD7vyctrp


Generated by Claude Code

pr-review-fixer hard-depended on the gh CLI, which isn't installed in
remote/cloud sessions (GitHub access there goes through mcp__github__*
tools instead). Adds a gh-availability check and an MCP-based fallback
path for fetch/resolve/reply, disclosed to its own gh-missing.md
(only loaded when gh turns out to be missing) rather than inlined for
every reader.

Ports chiptus/UpLine#503's SKILL.md change into this repo's copy of
the skill, already deduped per that PR's follow-up review.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776GRzBiT1RkWHD7vyctrp
Comment thread skills/chiptus/pr-review-fixer/SKILL.md Outdated
…p html_url

Ports UpLine#503's follow-up review fixes into this repo's copy:
- Phase 1's gh-availability check trimmed from six sentences to two;
  the auto-exec caveat was guarding against a documentation bug, not
  an agent-behavior risk, and doesn't apply once the check is plain
  prose with no `!` in it.
- Both gh branches now explicitly ask the user for the PR number when
  it isn't already clear from context, rather than assuming it's
  always derivable.
- gh-missing.md's Phase 1 now keeps html_url alongside author/body,
  which Phase 4 needs to build a reply.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776GRzBiT1RkWHD7vyctrp
@chiptus
chiptus merged commit 1187ec6 into main Sep 18, 2026
@chiptus
chiptus deleted the claude/upline-pr-503-review-0hr7uj branch September 18, 2026 10:46
chiptus added a commit that referenced this pull request Sep 28, 2026
…#5)

* fix(pr-review-fixer): add gh-missing fallback via mcp__github__ tools

pr-review-fixer hard-depended on the gh CLI, which isn't installed in
remote/cloud sessions (GitHub access there goes through mcp__github__*
tools instead). Adds a gh-availability check and an MCP-based fallback
path for fetch/resolve/reply, disclosed to its own gh-missing.md
(only loaded when gh turns out to be missing) rather than inlined for
every reader.

Ports chiptus/UpLine#503's SKILL.md change into this repo's copy of
the skill, already deduped per that PR's follow-up review.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776GRzBiT1RkWHD7vyctrp

* fix(pr-review-fixer): trim gh-check paragraph, ask for PR number, keep html_url

Ports UpLine#503's follow-up review fixes into this repo's copy:
- Phase 1's gh-availability check trimmed from six sentences to two;
  the auto-exec caveat was guarding against a documentation bug, not
  an agent-behavior risk, and doesn't apply once the check is plain
  prose with no `!` in it.
- Both gh branches now explicitly ask the user for the PR number when
  it isn't already clear from context, rather than assuming it's
  always derivable.
- gh-missing.md's Phase 1 now keeps html_url alongside author/body,
  which Phase 4 needs to build a reply.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01776GRzBiT1RkWHD7vyctrp

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants