Repository navigation
feat(link-wizard): save soundcloud followers #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chiptus
wants to merge
3
commits into
main
Choose a base branch
from
feat/UPL-39/linkwizard-soundcloud-followers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
supabase/migrations/20261013060000_soundcloud_admin_write_policies.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| -- Link Wizard persists the follower count of a selected SoundCloud candidate | ||
| -- from the admin client; previously only the sync function (service role) | ||
| -- could write this table. | ||
| CREATE POLICY "Admins can insert soundcloud data" ON public.soundcloud | ||
| FOR INSERT TO authenticated | ||
| WITH CHECK (public.can_edit_artists(auth.uid())); | ||
|
|
||
| CREATE POLICY "Admins can update soundcloud data" ON public.soundcloud | ||
| FOR UPDATE TO authenticated | ||
| USING (public.can_edit_artists(auth.uid())) | ||
| WITH CHECK (public.can_edit_artists(auth.uid())); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not adding this here: the existing Link Wizard integration suite stubs Spotify-only search results and I have no local Supabase to verify a new SoundCloud/RLS case. Unit tests cover the selection logic; the integration + non-admin RLS case is left for a follow-up.
Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should have access to staging supabase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The session only has the staging anon key (
VITE_SUPABASE_URL+ publishable key). The integration fixtures (signInAsTestUser,grantAdminRole) need the service-role admin API, and the harness is built for a local stack, so I can't run the test, and I'd rather not push one unverified. If you can expose a staging service-role key to the routine environment (or runpnpm run test:integrationlocally), I'll add the SoundCloud follower + non-admin RLS cases. Otherwise it's a follow-up.Generated by Claude Code