Skip to content

docs(agents): fix maintainer-commented PRs via skill #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiptus merged 3 commits into from
Oct 22, 2026
Merged

docs(agents): fix maintainer-commented PRs via skill #524

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a67726
docs(agents): act on maintainer PR comments via pr-review-fixer
claude Oct 11, 2026
7ec34a5
docs(agents): let fix worker triage maintainer comments itself
claude Oct 11, 2026
eb1f689
docs(agents): fix worker handles all unresolved PR comments
claude Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/agents/autonomic-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ All four hold → label `ready-for-agent`. Missing (a)/(b) → `needs-info`. Mis

## Fix firing

1. **Repair before build**: list Linear issues labeled `agent` with status `In Review` (`npx linearis issues list --team UPL --label agent --status "In Review"`) and follow each to its open linked PR — use `npx linearis issues read <identifier> --with-attachments` to find the linked GitHub PR, then `gh pr view <number>` to check its state; the Linear issue is the source of truth, nothing on GitHub needs to mirror it. If any such PR is conflicted with main or CI-red on its current head, restoring it (merge main in, get CI green through the quality gates) **is** this firing's work — then end. PRs the maintainer has left review comments on are his: leave them untouched. Broken agent PRs always stay counted against the cap — unreviewed PRs are exactly the review debt the cap limits.
1. **Repair before build**: list Linear issues labeled `agent` with status `In Review` (`npx linearis issues list --team UPL --label agent --status "In Review"`) and follow each to its open linked PR — use `npx linearis issues read <identifier> --with-attachments` to find the linked GitHub PR, then `gh pr view <number>` to check its state; the Linear issue is the source of truth, nothing on GitHub needs to mirror it. If any such PR is conflicted with main or CI-red on its current head, restoring it (merge main in, get CI green through the quality gates) **is** this firing's work — then end. Broken agent PRs always stay counted against the cap — unreviewed PRs are exactly the review debt the cap limits.
**Review comments**: an agent PR with any unresolved review comments (the maintainer's, review bots', anyone's) is also this firing's work, ahead of building anything new. Check out the PR's head branch (it works on the current branch), run the `pr-review-fixer` skill (Skill `pr-review-fixer`) there on all of its unresolved feedback. This firing is unattended, so skip Phase 3's wait for a reply and make the selection yourself: read each proposed fix and judge it **must** (do now), **nice to have** (do it if small and clearly right), or **defer** (leave it, reply with why or a proposal). Apply the must/nice items through the quality gates and push to that same PR branch, never a new one. Then end.
2. **Cap check**: same `agent` + `In Review` count as above; at or above 3 → end silently.
3. **Pick one issue**: `ready-for-agent` issues, skipping any with an assignee or an open linked PR, ordered by the native `priority` field — Urgent(1) → High(2) → Medium(3) → Low(4) → No priority(0) — oldest first within each rank (`npx linearis issues list --team UPL --label ready-for-agent --fields identifier,priority,createdAt`, sorted client-side since `--order-by` only covers `created`/`updated`). None eligible → end silently.
4. **Claim**: apply `agent` and move status to `In Progress` (`npx linearis issues update <identifier> --labels agent --label-mode add --status "In Progress"`) and post a claim discussion (timestamp + branch name) via `npx linearis issues discuss <identifier> --body "..."` before any work. Branch naming: generate the name per `docs/git-conventions.md` (issue-linked variant, e.g. `fix/UPL-448/consolidate-set-types`), overriding any pre-assigned `claude/...` name.
Expand Down
Loading