Repository navigation
refactor(festivals): use react-hook-form in FestivalDialog [UPL-77] - #523
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kJsstrWAyEUDmGUGfxtWn
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kJsstrWAyEUDmGUGfxtWn
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Core behavior is correct; only a non-blocking test-specificity gap remains.
1 open finding
What changed in this PR
Refactors FestivalDialog to use react-hook-form and Zod while preserving slug behavior.
Changes:
- Adds inline validation and form reset handling.
- Adds unit tests for validation, slug derivation, submission, editing, and reset.
| File | Description |
|---|---|
FestivalDialog.tsx |
Migrates festival form state and validation. |
FestivalDialog.test.tsx |
Tests the refactored form workflows. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kJsstrWAyEUDmGUGfxtWn
Owner
Author
|
Generated by Claude Code |
Playwright test results
Details
|
chiptus
commented
Oct 11, 2026
…-77] Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017W3hceGMCk65xmVAHs4s6f
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017W3hceGMCk65xmVAHs4s6f
chiptus
commented
Oct 12, 2026
…ts [UPL-77] Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017W3hceGMCk65xmVAHs4s6f
chiptus
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPL-77: moves the festival create/edit dialog from
useStateform state to react-hook-form with a zod schema, so name/slug errors show inline instead of as toasts. Slug auto-derive-until-edited and sanitize-on-keystroke behaviour are preserved.Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_016kJsstrWAyEUDmGUGfxtWn
Generated by Claude Code