Recover most of the old tests#294
Open
ketiltrout wants to merge 11 commits into
Open
Conversation
Also: * fix rest_server text fixture to read bodies from GET requests * --json and --yaml turn on quiet mode by default
Also: * default client method is now always GET * Re-implement --report-type (inadvertantly overlooked during client rewrite) * Some changes to rest_server fixture to make it more like the old rest_farm fixture.
Also: * Add a `call_endpoint` method to `coco_runner` to simplify direct access to the daemon (i.e. without using the client).
Also: * handle broken pipe in rest_server fixture
Also: * Add all the local endpoint names to the list of all endpoints we check forwards against
This is the simulate-chime stuff and the test_saved_states.py whose tests have been duplicated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a working client, this recovers all the old tests in
old_testsexcept for two files which involve the still-kind-of-broken prometheus metrics server, which I'm going to leave to a later PR.All the recovered tests are tests of the
cocodbackend (the qworker), which hasn't really changed in the upgrade, so there are very few changes to coco per se. I have done some work on the newcoco_runnerandrest_serverfixtures to make them work more like the old fixtures did.Substantive changes to coco:
cocodchecks against when trying to find missing endpoint targets (which was introduced in fix(endpoint): Ensure internal forwards exist #288)-r"report-type" flag in the client, support for which I apparently accidentally deleted during the client re-write--jsonand--yamlnow turn on silent mode (unless explicitly told not to) to guarantee that the client output is parseable as the requested format.Also deleted the old
simulate-chimewhich I don't think has a use anymore.Requires #293