[DONT MERGE] Test PR for commenting extension with diff by chienyuanchang · Pull Request #2 · chienyuanchang/rich-diff-comments

chienyuanchang · 2026-05-19T16:31:04Z

No description provided.

chienyuanchang · 2026-05-20T06:32:36Z

-This is the **overview paragraph**. It contains _emphasis_, `inline code`, and a [link to docs](https://example.com/docs). The goal is to have several paragraphs in a row so the text-matcher has to handle ordering.
+This is the **overview paragraph**. It contains _emphasis_, `inline code`, and a [link to the docs](https://example.com/docs). The goal is to have several paragraphs in a row so the text-matcher has to handle ordering across small edits.

 A second paragraph follows directly. Reviewers should be able to:


The numbered list below already covers item 1 ("comment on a whole paragraph"). Should we deduplicate, or is the prose intro worth keeping for context?

chienyuanchang · 2026-05-20T06:33:20Z

@@ -1,12 +1,15 @@
 # Test Design Doc: Sample Feature Integration

 > **Area**: testing


Should we tag this as area: testing-tools so the dashboard groups it correctly?

Good catch — I'll update the dashboard label list.(updated)

chienyuanchang · 2026-05-20T06:38:26Z


 ---

 ## Architecture


Add a brief one-line summary under this heading so readers skimming the outline know what's in here.

chienyuanchang · 2026-05-20T06:38:49Z

    A-->>U: response
 ```

 ### Impact Analysis


Should this section explicitly call out backward compatibility for the schema changes?

chienyuanchang · 2026-05-20T06:39:11Z


 ---

 ## Implementation Phases


Three phases feels right. Add expected duration per phase?

chienyuanchang · 2026-05-20T06:39:31Z


 ---

 ## Risks


Add a row covering API stability assumptions — Service.handle relies on a 3rd-party SDK.

chienyuanchang · 2026-05-20T21:37:50Z

 **Goal**: Get the new service plumbing in place without changing observable behavior.

 **Approach**: Add `Service` class with `accepts()` and `handle()` methods. Wire it into `Application.start` but only activate when an opt-in kwarg is set. Default path remains unchanged.

 **Dependencies**: none.


we can comment on multiple lines

chienyuanchang · 2026-05-29T02:01:38Z

+     - [ ] `validate()` raises on malformed payloads
     - [ ] `handle()` returns a valid `Response` for an accepted request

 2. **Wire into the constructor**


test first level

chienyuanchang · 2026-05-29T02:01:50Z

@@ -162,6 +184,8 @@

 - [ ] Unit: each supported type routes to the expected backend


chienyuanchang · 2026-05-29T02:02:01Z

+   - Add `metrics.increment("service.backend.<name>")` per dispatch
+   - Add `metrics.increment("cache.hit")` / `metrics.increment("cache.miss")`
+   - Acceptance criteria:
+     - [ ] Counters fire on every relevant code path


chienyuanchang · 2026-05-29T02:02:09Z

+1. **Counters**
+   - File: `src/app/service.py`, `src/app/cache.py`
+   - Add `metrics.increment("service.backend.<name>")` per dispatch
+   - Add `metrics.increment("cache.hit")` / `metrics.increment("cache.miss")`


first child

chienyuanchang · 2026-05-29T02:02:26Z

@@ -354,10 +442,13 @@

 - [GitHub PR Review API](https://docs.github.com/en/rest/pulls/comments)


one-level list

chienyuanchang · 2026-05-29T19:51:46Z


 ## Table of Contents

 - [Overview](#overview)


chienyuanchang · 2026-05-29T19:52:05Z

    print(f"rejected: {e}")
 ```

 ### Shell


chienyuanchang · 2026-05-29T19:52:27Z


 A second paragraph follows directly. Reviewers should be able to:

 1. Comment on this entire paragraph from rich diff


single list?

add for testing

7c0546e

chienyuanchang commented May 20, 2026

View reviewed changes

Comment thread test_md_files/sample-design-doc.md

chienyuanchang commented May 20, 2026

View reviewed changes

chienyuanchang commented May 29, 2026

View reviewed changes

Comment thread test_md_files/sample-design-doc.md

## Table of Contents

- [Overview](#overview)

chienyuanchang May 29, 2026

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

chienyuanchang commented May 29, 2026

View reviewed changes

Comment thread test_md_files/sample-design-doc.md

print(f"rejected: {e}")

```

### Shell

chienyuanchang May 29, 2026

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here?

chienyuanchang commented May 29, 2026

View reviewed changes

		@@ -1,12 +1,15 @@
		# Test Design Doc: Sample Feature Integration

		> Area: testing

		@@ -162,6 +184,8 @@

		- [ ] Unit: each supported type routes to the expected backend

		@@ -354,10 +442,13 @@

		- [GitHub PR Review API](https://docs.github.com/en/rest/pulls/comments)


		A second paragraph follows directly. Reviewers should be able to:

		1. Comment on this entire paragraph from rich diff

Conversation

chienyuanchang commented May 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chienyuanchang May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chienyuanchang May 20, 2026 •

edited

Loading