docs: writes honour the per-call workspace override - #9
Merged
Conversation
usage.md still said writes ignore the workspace argument and always target the connection's own workspace. That stopped being true in #8: mcp.go applies scopeOverride to every non-registry tool, so create_doc, update_doc, retag_doc, soft_delete_doc, restore_doc, hard_delete_doc, create_folio and add_folio_file all place the write in the named workspace. Verified against a running v1.4.3 by creating, soft-deleting, restoring and hard-deleting a probe document in another workspace from a default-pinned connection: it resolved there throughout and returned not found in default. Also notes the two registry tools that legitimately ignore it, and keeps the recommendation to pin a connection for sustained work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web/usage.md(served at/llms.txtand/usage.md) still told agents:That stopped being true in #8.
mcp.go:100appliesscopeOverrideto every non-registry tool, so all eight write tools honourworkspaceand place the write where it names.The stale sentence is load-bearing for agents — it is the doc they are pointed at — and it caused a wrong conclusion today before the code was checked.
Verified against a running v1.4.3
Created, soft-deleted, restored and hard-deleted a probe document in
test-temp-wsfrom adefault-pinned connection. It resolved intest-temp-wsand returnednot foundindefaultthroughout, and hard delete correctly rejected a mismatchedconfirm.This PR
workspacelist_workspaces/create_workspacelegitimately ignore it, acting on the registry rather than inside a workspaceX-Workspacefor sustained workDocs only; no behaviour change.