Skip to content

Comments

fix/navbar and logout#33

Merged
CMolinaBetancourt merged 1 commit intomainfrom
navbarmenu
Dec 10, 2025
Merged

fix/navbar and logout#33
CMolinaBetancourt merged 1 commit intomainfrom
navbarmenu

Conversation

@CMolinaBetancourt
Copy link
Collaborator

@CMolinaBetancourt CMolinaBetancourt commented Dec 8, 2025

🎯Type of Change (Select one or more):

  • Fix 🐛: Correction of an error in logout.
  • Style 🎨: Aesthetic changes (CSS).

This PR...

Fix the link in the hamburger navigation menu, set the navbar text to bold when the user clicks on the links, and correct the logout functionality


📝 What I Did (Detailed Work):

  • Link: Check and adjust the link on the hamburger menu.
  • Text bold in navbar: Added useLocation to the navbar.
  • Logout functionality: Added _redirects in /public to redirect all routes to index.html.

🧪 How to Test (Steps to Verify):

  1. Navigate to preview deploy.
  2. Sign in.
  3. From the navbar, go to different pages and validate that the link of the page where you are located turns bold.
  4. Switch to mobile view and test the hamburger menu links.
  5. Navigate to the logout option in the navbar and in the profile page, and test them.

🤔 What I learned (gotchas):

I learned why React applications have 404 errors when reloading pages in production, the server looks for physical files that don't exist. One solution is to use redirects so that all routes serve index.html and let React Router handle the rest.

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for mint-chip ready!

Name Link
🔨 Latest commit 6bc97f5
🔍 Latest deploy log https://app.netlify.com/projects/mint-chip/deploys/693707398a44b10008c22eb4
😎 Deploy Preview https://deploy-preview-33--mint-chip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CMolinaBetancourt CMolinaBetancourt changed the title fix/navbar fix/navbar and logout Dec 8, 2025
Copy link
Collaborator

@nkabembo nkabembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things work great. Interesting, the logout issue is caused by react and not netlify?

@CMolinaBetancourt CMolinaBetancourt merged commit 7c4cdb9 into main Dec 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants