Closed
Conversation
✅ Deploy Preview for mint-chip ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯Type of Change (Select one or more):
This PR...
📝 What I Did (Detailed Work):
Remember that other changes appear that were caused by running the format and lint commands
🧪 How to Test (Steps to Verify):
¡Me parece una lista de pruebas muy clara y completa! Has cubierto la configuración, la inclusión/exclusión de datos, la navegación y la funcionalidad clave de la redirección.
Solo tengo una sugerencia menor para el paso de verificación en el punto 6 y el formato de los puntos.
📝 Sugerencia de Ajuste
optOut): En la práctica de Firebase, si la opción no se marca, el campooptOuta menudo no se guarda en el documento. Lo más seguro es verificar que seafalseo que no exista. Esto hace la instrucción de prueba más robusta.optOut: false) y exclusión (optOut: true). Aquí la PR es más concisa, pero perdemos la verificación de la exclusión.Aquí tienes la versión ajustada para una máxima claridad y precisión técnica:
🧪 How to Test (Steps to Verify):
1. ⚙️ Setup
feat/communityForum.journalline 17:const USER_ID = 'user-id';to a new ID, e.g.,user-id2. Check Firestore to ensure the ID has not been used.2. 🔒 Test Privacy and Saving (Daily Summary)
journalscollection has theoptOutfield asfalseor is missing entirely.optOutfield set totrue.3. Test the Community Page (
/community)/community)./community/responses/[day]).4. Test the Responses Page and Privacy Logic
5. Test Redirection (Empty Case)
/journalpage and automatically open the Daily Summary for that specific day.🤔 What I learned (gotchas):
I didn't know Firebase, and it's a very friendly database.