Conversation
✅ Deploy Preview for mint-chip ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nkabembo
left a comment
nkabembo
left a comment
There was a problem hiding this comment.
Things look good. it is responsive
Suggestion: When for the navigation buttons maybe a delay is good the speed is fast when button is clicked
I got some feedback while using IBM accessibility checker this is the feedback. Suggestion you can test it out using IBM to get more context on the feedback. I got
1.For Healie in nav link this was comment - Violation Content is not within a landmark element. What i noticed when Healie is clicked nothing happens except cursor shows is it clear to any user that they have clicked even though it remains on page .suggestion: adding an outline
2. Multiple elements with "main" role do not have unique labels
3. Confirm this text 'Woman who completed Guided Journaling' is used as a heading and if so, modify to use a heading element or role. - In the women in tech section with the card the headings are simply in p tag maybe changing the tag to heading of the role would help with that
|
Thank you for the review, I have corrected the main points. Please check it and let me know |
I think most of the issues are fixed for accessibility. I just had a question about focus visible outline. when clicking Healie no outline shows but outline shows everywhere else. Also when I clicked tab the outline is black while when I click the outlines is blue. Having a consistent focus-visible color will be good. Also for the buttons I am not sure if I was clear but when clicking it flashes really fast and moves to another page. Maybe slowing down button or link speed be nice so that the transition to another page is quick but the button does not flash. Not sure if that is clear. |
|
|
the outlines for keyboard use are not fine. I notice that the buttons when clicked have active color of blue which is fine since I am not using the key board so no outline is needed based on my understanding. Only the signup button has an outline when clicked. Suggestion: removing the outline for that button so it matches the other buttons |
magali-la
left a comment
magali-la
left a comment
There was a problem hiding this comment.
note: shifting alignment of check icon and titles containers on the check cards across breakpoints
suggestion: Revisit items-start class. React icons has check icons, that look the same, which you could change the colors of as an option
According to what I understood, I should wait for the button component to be ready to import it from there. That is the reason I took all the code related to buttons |
ok |
3 participants
🎯Type of Change (Select one or more):
This PR...
is for the home page and its components.
📝 What I Did (Detailed Work):
🧪 How to Test (Steps to Verify):
Provide clear, numbered steps for reviewers to manually test and verify your changes.
🤔 What I learned (gotchas):
I learned responsive design and how to work with the button as a component. In Figma I learned how to use Figma plugins to translate the design into Tailwind, which facilitates the rendering process.