Skip to content

Comments

Feat/page routing#14

Merged
nkabembo merged 4 commits intomainfrom
feat/page-routing
Oct 19, 2025
Merged

Feat/page routing#14
nkabembo merged 4 commits intomainfrom
feat/page-routing

Conversation

@nkabembo
Copy link
Collaborator

@nkabembo nkabembo commented Oct 15, 2025

  • Feat ✨: New feature or functionality.

This PR...

--- This PR introduces basic page routing to the application

📝 What I Did (Detailed Work):

  • Installed React router dom
  • Deleted App.jsx as it is not needed for routing
  • Created Router using createBrowserRouter and created paths in main.jsx
  • Modified pages to test routing works properly

🧪 How to Test (Steps to Verify):

  1. Run git checkout feat/page-routing
  2. Run npm install to check that react-router-dom exists in node modules
  3. Run npm run dev . On the home page there are links to all pages check that they work
  4. The links will either be found on / or /pagename depending on type of page will show navbar , footer or not
  5. To test that Error page works modify the url to whatever you want and make sure it leads to the error page

🤔 What I learned (gotchas):

How to create routes in latest react router dom

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for mint-chip ready!

Name Link
🔨 Latest commit 05028d3
🔍 Latest deploy log https://app.netlify.com/projects/mint-chip/deploys/68f402dc60d29800087d8198
😎 Deploy Preview https://deploy-preview-14--mint-chip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@magali-la magali-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge
note: the ternary for the nav repeats the component.
suggestion: simplify the ternary. The navbar component itself would include the two nav styles and determine when they are rendered

@nkabembo nkabembo merged commit 2a32421 into main Oct 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants