Repository navigation
feat(compat): support DSH 0.2.2-rc.2 - #30
Merged
Merged
Conversation
cherrchen
force-pushed
the
feat/adapt-1111-rc2
branch
4 times, most recently
from
November 11, 2026 15:16
7bffdac to
6185176
Compare
- Add 0.2.2-rc.2 to the release list, every DSH peer OR, engines.dsh and the optional credentials subset. Its Cordis 4.1.0 / cosmokit 1.9.0 / schemastery 3.19.0 copies match rc.1 and stay inside the declared ranges. - Route the commit-options dropdown through src/compat/dsh-menu.tsx: rc.2 removes Menu.getAnchorRect for the CSS anchorRef, earlier copies measure the callback, so the compat layer probes whether the installed Menu still reads getAnchorRect. 0.2.2-alpha.3 through rc.1 also name an internal anchorRef option, so that name alone does not identify the interface. - Run the 0.2.2-rc.2 CI lane on Node 24.9.0 with the other 0.2.2 hosts. - Document the seam review in the compatibility contract. Lane evidence is pending because the rc.2 npm packages are not published yet.
cherrchen
force-pushed
the
feat/adapt-1111-rc2
branch
from
November 11, 2026 15:29
6185176 to
95681c6
Compare
- Record that 0.2.2-rc.2 is on npm (dist-tag next) and that every declared DSH peer exists at that version. - Verify the published dsh-client-ui-primitives@0.2.2-rc.2 Menu signature keeps anchorRef/anchorPoint and no getAnchorRect, so the compat probe picks ref on rc.2 and rect on rc.1. - Record the green rc.2 matrix lane (24 releases), local development-pin gates, and the 28-test browser fixture on the development pin and rc.2. - Changelog no longer calls the release unpublished.
cherrchen
marked this pull request as ready for review
November 12, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the verified compatibility range from
0.2.2-rc.1to the upstream tagdsh-v0.2.2-rc.2, the current0.2.2release candidate and now a published npm release (@deepseek-ai/dsh@0.2.2-rc.2, dist-tagnext). The development pin and committed lockfile stay on0.2.0-rc.2.An earlier revision of this PR stayed a draft because the
0.2.2-rc.2npm packages were missing from the registry. They were published on 2026-11-12. This revision re-checks the adaptation against the published packages, records the resulting lane and browser evidence, and drops the draft state.Interface review (upstream tags)
dsh-v0.2.2-rc.1(66491b05e3) →dsh-v0.2.2-rc.2(ddac96760b): 4645 files changed in the tree; the directories this plugin consumes contain 1001 changed files. This is a real feature release (menu positioning and submenus, session history paging and retry, worktree archive cleanup, Forge and Agent Team panels), not a version-only republish. No packages were added or removed between the tags.The packages this plugin consumes were checked against its actual seams:
dsh-client-ui-primitivesremovesMenu.getAnchorRectand theuseAnchoredPosition/AnchoredPositionOptionsexports; portal menus now use CSS Anchor Positioning viaanchorRef/anchorPoint(upstream upgrade guidev0.2.2-alpha.2/css-anchored-menus).hocslot kind and renderer layers,conversation.hero.frame, composer file-intake route,insertQuote(text, summary?),openSettings(sectionId?),Modal.tone,QuotePreview.summary, new icons. The slots and props Git registers or reads keep their contracts.dsh-subprocess/error.ts(SubprocessError, stable codes); a pre-aborted spawn now throwsAbortErrorand empty argv throwsSUBPROCESS_INVALID_ARGV.resolveExecutable,spawn,CollectedOutputand platform rejections are unchanged.CredentialInfo.maskedadded (optional) — the DeepSeek account provider rewrite stays host-internal;WorkingDirectoryErrorcodes and aworking-directory/accesswaterfall,get/setunchanged; worktree archive cleanup recordsplugin:worktree/createdbutcreate(agent, request, signal)is unchanged;dsh-fsaddsFS_ALREADY_EXISTS/fsErrorFromErrnoonly,resolve/lstat/writeTextunchanged.AgentRegistrydropsparentAgent,isOwnedBy,roots()(Git only callsagents.get). Session snapshots gain history fields;SessionSummary.cwd/projectionValuesunchanged.LlmErrorcodes are tightened;streamtext-delta/GenerateOptionsunchanged.4.1.0, cosmokit1.9.0, schemastery3.19.0— the same copies as0.2.2-rc.1, already inside the declared ranges. No new OR clause.Adaptation
src/compat/dsh-menu.tsxaddsAnchoredMenu, which supplies the anchor input the installed release reads. The probe asks whether the installedMenustill reads the removedgetAnchorRect:0.2.2-alpha.3throughrc.1also use an internalanchorRefoption in their positioning hook, so the newer prop's presence alone misidentifies those releases (the first matrix run caught exactly that).src/client/details/CommitRegion.tsxnow hands over the chevron's ref instead of a measuring callback. The other four Git menus render their trigger inline, so they need no anchor input.0.2.2-rc.2is added toSUPPORTED_DSH_RELEASES,CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR andengines.dsh.0.2.2-rc.2lane joins the other0.2.2hosts on Node24.9.0.Validation
Published packages.
@deepseek-ai/dsh@0.2.2-rc.2is on npm (dist-tagnext;latestremains0.2.2-rc.1), declares Node>=24.9.0and the same Cordis4.1.0/ schemastery3.19.0copies asrc.1. All seventeen declared DSH peers, including the optionaldsh-credentials, exist at that version. The publisheddsh-client-ui-primitives@0.2.2-rc.2Menusignature keepsanchorRef/anchorPointand itslib/no longer containsgetAnchorRect;rc.1's signature still reads the callback. The probe therefore selectsrefonrc.2andrectonrc.1and on the copying releases between them.Local gates (development pin
0.2.0-rc.2).pnpm compat:check— list, peer ORs,engines.dsh, dev pins and installed packages agree.pnpm test— 1047 passed in 80 files (1043 before; 4 new).pnpm docs:check— passes.pnpm buildandpnpm test:artifact— 7 artifact checks pass.pnpm pack— producesdsh-electron-dsh-plugin-git-0.2.9.tgz.pnpm test:e2e— 28 passed on the development pin; the same suite passes 28/28 in an isolated copy installed with the published0.2.2-rc.2host. The fixture browser does not cover the full DSH shell or real accounts.Compatibility matrix (CI). All 24 exact releases pass bootstrap, upgrade, install, peers, compat, tests, docs, build, artifact and pack. On
verify (0.2.2-rc.2)(Node24.9.0) the lane reports 80 test files / 1047 tests, including the 4 newdsh-menutests, and 7 artifact checks; the tarball containslib/types/compat/dsh-menu.d.ts.New
tests/dsh-menu.client.spec.tsxcovers both anchor shapes as pure functions and asserts, per installed host, that the portal list lands on the supplied trigger rect (legacy branch) or publishes it as the CSS anchor (new branch). The compatibility contract records the seam review and the evidence:docs/reference/dsh-compatibility.md.Not covered
0.2.2-rc.2; the browser fixture is not the full shell.CI results
DSH compatibility matrixrun 43213526563 on head3c769c9: all 24 lanes pass, includingverify (0.2.2-rc.2)at 1m46s and every previously supported release.CIrun 43213526506 on the same head: Ubuntu, macOS and Windows all pass install, peers,compat:check, the full test suite, the three acceptance replays, Chromium E2E,docs:check, build, artifact and pack.data-menu-materialattribute, plus0.2.2-alpha.3/rc.1where the probe misidentified the interface); the probe and the test selectors were corrected before this head.