Skip to content

feat(compat): support DSH 0.2.2-rc.2 - #30

Merged
cherrchen merged 2 commits into
mainfrom
feat/adapt-1111-rc2
Nov 12, 2026
Merged

cherrchen merged 2 commits into
mainfrom
feat/adapt-1111-rc2

Conversation

@cherrchen

@cherrchen cherrchen commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Extends the verified compatibility range from 0.2.2-rc.1 to the upstream tag dsh-v0.2.2-rc.2, the current 0.2.2 release candidate and now a published npm release (@deepseek-ai/dsh@0.2.2-rc.2, dist-tag next). The development pin and committed lockfile stay on 0.2.0-rc.2.

An earlier revision of this PR stayed a draft because the 0.2.2-rc.2 npm packages were missing from the registry. They were published on 2026-11-12. This revision re-checks the adaptation against the published packages, records the resulting lane and browser evidence, and drops the draft state.

Interface review (upstream tags)

  • dsh-v0.2.2-rc.1 (66491b05e3) → dsh-v0.2.2-rc.2 (ddac96760b): 4645 files changed in the tree; the directories this plugin consumes contain 1001 changed files. This is a real feature release (menu positioning and submenus, session history paging and retry, worktree archive cleanup, Forge and Agent Team panels), not a version-only republish. No packages were added or removed between the tags.

The packages this plugin consumes were checked against its actual seams:

Seam Result
Menu anchoring Breaking for this plugin. dsh-client-ui-primitives removes Menu.getAnchorRect and the useAnchoredPosition / AnchoredPositionOptions exports; portal menus now use CSS Anchor Positioning via anchorRef / anchorPoint (upstream upgrade guide v0.2.2-alpha.2/css-anchored-menus).
Other client seams Additions only: hoc slot kind and renderer layers, conversation.hero.frame, composer file-intake route, insertQuote(text, summary?), openSettings(sectionId?), Modal.tone, QuotePreview.summary, new icons. The slots and props Git registers or reads keep their contracts.
Host Git / subprocess Error types move to dsh-subprocess/error.ts (SubprocessError, stable codes); a pre-aborted spawn now throws AbortError and empty argv throws SUBPROCESS_INVALID_ARGV. resolveExecutable, spawn, CollectedOutput and platform rejections are unchanged.
Credentials / directory / worktree CredentialInfo.masked added (optional) — the DeepSeek account provider rewrite stays host-internal; WorkingDirectoryError codes and a working-directory/access waterfall, get / set unchanged; worktree archive cleanup records plugin:worktree/created but create(agent, request, signal) is unchanged; dsh-fs adds FS_ALREADY_EXISTS / fsErrorFromErrno only, resolve / lstat / writeText unchanged.
Agent / Session / LLM AgentRegistry drops parentAgent, isOwnedBy, roots() (Git only calls agents.get). Session snapshots gain history fields; SessionSummary.cwd / projectionValues unchanged. LlmError codes are tightened; stream text-delta / GenerateOptions unchanged.
Shared runtime Cordis 4.1.0, cosmokit 1.9.0, schemastery 3.19.0 — the same copies as 0.2.2-rc.1, already inside the declared ranges. No new OR clause.

Adaptation

  • Menu anchoring. src/compat/dsh-menu.tsx adds AnchoredMenu, which supplies the anchor input the installed release reads. The probe asks whether the installed Menu still reads the removed getAnchorRect: 0.2.2-alpha.3 through rc.1 also use an internal anchorRef option in their positioning hook, so the newer prop's presence alone misidentifies those releases (the first matrix run caught exactly that). src/client/details/CommitRegion.tsx now hands over the chevron's ref instead of a measuring callback. The other four Git menus render their trigger inline, so they need no anchor input.
  • Declarations. 0.2.2-rc.2 is added to SUPPORTED_DSH_RELEASES, CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR and engines.dsh.
  • CI. The 0.2.2-rc.2 lane joins the other 0.2.2 hosts on Node 24.9.0.
  • Not added to peer OR. No new packages exist in this release; nothing was added.

Validation

Published packages. @deepseek-ai/dsh@0.2.2-rc.2 is on npm (dist-tag next; latest remains 0.2.2-rc.1), declares Node >=24.9.0 and the same Cordis 4.1.0 / schemastery 3.19.0 copies as rc.1. All seventeen declared DSH peers, including the optional dsh-credentials, exist at that version. The published dsh-client-ui-primitives@0.2.2-rc.2 Menu signature keeps anchorRef / anchorPoint and its lib/ no longer contains getAnchorRect; rc.1's signature still reads the callback. The probe therefore selects ref on rc.2 and rect on rc.1 and on the copying releases between them.

Local gates (development pin 0.2.0-rc.2).

  • pnpm compat:check — list, peer ORs, engines.dsh, dev pins and installed packages agree.
  • pnpm test — 1047 passed in 80 files (1043 before; 4 new).
  • pnpm docs:check — passes.
  • pnpm build and pnpm test:artifact — 7 artifact checks pass.
  • pnpm pack — produces dsh-electron-dsh-plugin-git-0.2.9.tgz.
  • pnpm test:e2e — 28 passed on the development pin; the same suite passes 28/28 in an isolated copy installed with the published 0.2.2-rc.2 host. The fixture browser does not cover the full DSH shell or real accounts.

Compatibility matrix (CI). All 24 exact releases pass bootstrap, upgrade, install, peers, compat, tests, docs, build, artifact and pack. On verify (0.2.2-rc.2) (Node 24.9.0) the lane reports 80 test files / 1047 tests, including the 4 new dsh-menu tests, and 7 artifact checks; the tarball contains lib/types/compat/dsh-menu.d.ts.

New tests/dsh-menu.client.spec.tsx covers both anchor shapes as pure functions and asserts, per installed host, that the portal list lands on the supplied trigger rect (legacy branch) or publishes it as the CSS anchor (new branch). The compatibility contract records the seam review and the evidence: docs/reference/dsh-compatibility.md.

Not covered

  • No local Linux/Windows run; CI owns the platform matrix.
  • No full DSH Web/Desktop profile installation on 0.2.2-rc.2; the browser fixture is not the full shell.
  • No real remote account acceptance.

CI results

  • DSH compatibility matrix run 43213526563 on head 3c769c9: all 24 lanes pass, including verify (0.2.2-rc.2) at 1m46s and every previously supported release.
  • CI run 43213526506 on the same head: Ubuntu, macOS and Windows all pass install, peers, compat:check, the full test suite, the three acceptance replays, Chromium E2E, docs:check, build, artifact and pack.
  • The first matrix run on the earlier head failed nine lanes only in the new test (old hosts without the data-menu-material attribute, plus 0.2.2-alpha.3 / rc.1 where the probe misidentified the interface); the probe and the test selectors were corrected before this head.

@cherrchen
cherrchen force-pushed the feat/adapt-1111-rc2 branch 4 times, most recently from 7bffdac to 6185176 Compare November 11, 2026 15:16
- Add 0.2.2-rc.2 to the release list, every DSH peer OR, engines.dsh and the
  optional credentials subset. Its Cordis 4.1.0 / cosmokit 1.9.0 /
  schemastery 3.19.0 copies match rc.1 and stay inside the declared ranges.
- Route the commit-options dropdown through src/compat/dsh-menu.tsx: rc.2
  removes Menu.getAnchorRect for the CSS anchorRef, earlier copies measure the
  callback, so the compat layer probes whether the installed Menu still reads
  getAnchorRect. 0.2.2-alpha.3 through rc.1 also name an internal anchorRef
  option, so that name alone does not identify the interface.
- Run the 0.2.2-rc.2 CI lane on Node 24.9.0 with the other 0.2.2 hosts.
- Document the seam review in the compatibility contract. Lane evidence is
  pending because the rc.2 npm packages are not published yet.
- Record that 0.2.2-rc.2 is on npm (dist-tag next) and that every declared
  DSH peer exists at that version.
- Verify the published dsh-client-ui-primitives@0.2.2-rc.2 Menu signature
  keeps anchorRef/anchorPoint and no getAnchorRect, so the compat probe picks
  ref on rc.2 and rect on rc.1.
- Record the green rc.2 matrix lane (24 releases), local development-pin
  gates, and the 28-test browser fixture on the development pin and rc.2.
- Changelog no longer calls the release unpublished.
@cherrchen
cherrchen marked this pull request as ready for review November 12, 2026 11:57

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cherrchen
cherrchen merged commit b52de0c into main Nov 12, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant